[Bug 1998513] Re: SRU provide RISCV_EFI_BOOT_PROTOCOL in Focal

[Dave Jones]

In the patch, in efi_riscv_get_boot_hartid, should this:

  return EFI_INVALID_PARAMETER

have a reference to EFI_EXIT, i.e.:

  return EFI_EXIT(EFI_INVALID_PARAMETER)

It appears in other EFI implementations within u-boot that whenever
EFI_ENTRY is called, EFI_EXIT is called on exit of the function (whether
successful or not)? I assume this is a fairly minor note though, as
presumably in this case boot is going to fail anyway.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1998513

Title:
  SRU provide RISCV_EFI_BOOT_PROTOCOL in Focal

Status in u-boot package in Ubuntu:
  In Progress

Bug description:
  [ Impact ]

  Booting a current kernel (5.19) with U-Boot via UEFI fails in Focal
  because the RISCV_EFI_BOOT_PROTOCOL is not provided.

  The RISCV_EFI_BOOT_PROTOCOL is used to indicate the boot hart ID. In
  previous releases of the kernel the boot hart ID was read from the
  /chosen/boot-hartid property in the device-tree.

  Add the missing protocol.

  U-Boot in Focal cannot add the boot-hartid property if the the device-
  tree does not contain a chosen node. This might lead to failure to
  boot a 5.15 kernel. Add a patch fixing this.

  [ Test Plan ]

   * Try booting the SiFive HiFive Unmatched board and QEMU using the
  preinstalled server image for Focal.

   * Use the Kinetic server install image to install Ubuntu on the
  SiFive HiFive Unmatched board and on QEMU and try to boot with the
  SRUed U-Boot.

  [ Where problems could occur ]

   * The two applied patches affect only RISC-V (if there is no syntax
  error).

   * Booting the Focal Fossa 5.15 kernel would fail if the /chosen/boot-
  hartid were not provided.

  [ Other Info ]
   
  n/a

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/u-boot/+bug/1998513/+subscriptions