[Merge] ~mitchburton/ubuntu/+source/landscape-client:ubuntu/lunar-devel into ubuntu/+source/landscape-client:ubuntu/lunar-devel

[Mitch Burton]

My apologies. I didn't realize launchpad was going to obliterate past inline comments if I pushed new commits. Since I can no longer view the previous diff comments for some reason I've reproduced them here for posterity:

/debian/landscape-client.postrm L29
> +    rm -f "${GPG_DIR}/landscape-server"*.asc

ahasenack: I understand this is using globbing because of the random suffix that the landscape-server gpg key filename gets, but isn't there a risk here that we could be deleting another gpg key that isn't strictly ours? Perhaps someone is hosting LDS on premises, and named the key that signs their local repository `landscape-server-mycompany.asc`?

mitchburton: Yes, that risk certainly exists. It would probably be better to use a key filename that makes it explicit that the file was created by Landscape, something like "landscape-server-{repository_name}.asc" or similar.


/landscape/client/manager/aptsources.py L85
> +            filename = prefix + str(uuid.uuid4()) + '.asc'

ahasenack: Why a random name for the landscape-server gpg key file?

silverdrake11: There can be multiple keys sent from landscape server, they are not named. One option I considered was calculating the fingerprint but this required an additional dependency.


/landscape/client/manager/aptsources.py L85
(same line as above)

ahasenack: Also note that an `.asc` gpg key is only supported by apt >= 1.4, as per https://manpages.ubuntu.com/manpages/jammy/man8/apt-key.8.html#deprecation. Checking rmadison, only trusty and xenial have a lower version of apt, so if you ever intend to SRU this to those ubuntu releases, it won't work. Bionic already has apt 1.6.x.

mitchburton: Noted. I don't expect to SRU to trusty or xenial.
-- 
https://code.launchpad.net/~mitchburton/ubuntu/+source/landscape-client/+git/landscape-client/+merge/437634
Your team Ubuntu Sponsors Team is requested to review the proposed merge of ~mitchburton/ubuntu/+source/landscape-client:ubuntu/lunar-devel into ubuntu/+source/landscape-client:ubuntu/lunar-devel.