[Bug 1993621] Re: Force update keyboard LEDs after calling EnableDevice to fix its state after VT switching
Yao Wei
1993621 at bugs.launchpad.net
Tue Feb 21 05:59:31 UTC 2023
Attached is the debdiff for the following Merge Request merged upstream:
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1070
Please review
** Description changed:
+ [ Impact ]
+
+ * This change will force update keyboard LED status after calling
+ EnableDevice, in order to resolve LED status not syncing after switching
+ VT to a X session.
+
+ * This also fixes the issue with NVIDIA driver and Xorg, that after
+ resuming from suspend the keyboard LED is always off.
+
+ [ Test Plan ]
+
+ 1. Log on a X session desktop (GNOME Xorg for example)
+
+ 2. Turn on NumLock on the keyboard
+
+ 3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to
+ switch back to desktop
+
+ NumLock LED should be on after switching back to the desktop
+
+ [ Where problems could occur ]
+
+ * The changes are to push status to the device when enabling it
+ regardless of actual keyboard state change, therefore switching between
+ VTs and adding/removing keyboard/mouse/xinput devices should be affected
+ by this change.
+
+ [ Original Report ]
+
Switching virtual terminals [Ctrl-Alt-F1 - F7] to a X session turns off
keyboard LEDs.
This issue is reproducible on 2:21.1.3-2ubuntu2.1 (on 22.04)
To reproduce:
1. Log on a X session desktop (GNOME Xorg for example)
2. Turn on NumLock
3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to switch back to desktop
Expected:
NumLock LED should be on
Actual:
NumLock LED is off, but functions like NumLock is on. If NumLock is pressed the LED turns off as well as the function. If CapsLock is pressed the LED states sync back (LED turns back on).
** Description changed:
[ Impact ]
- * This change will force update keyboard LED status after calling
+ * This change will force update keyboard LED status after calling
EnableDevice, in order to resolve LED status not syncing after switching
VT to a X session.
- * This also fixes the issue with NVIDIA driver and Xorg, that after
+ * This also fixes the issue with NVIDIA driver and Xorg, that after
resuming from suspend the keyboard LED is always off.
[ Test Plan ]
- 1. Log on a X session desktop (GNOME Xorg for example)
+ 1. Log onto an GNOME session (KDE Kwin worked this issue around)
2. Turn on NumLock on the keyboard
3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to
switch back to desktop
NumLock LED should be on after switching back to the desktop
[ Where problems could occur ]
- * The changes are to push status to the device when enabling it
+ * The changes are to push status to the device when enabling it
regardless of actual keyboard state change, therefore switching between
VTs and adding/removing keyboard/mouse/xinput devices should be affected
by this change.
[ Original Report ]
Switching virtual terminals [Ctrl-Alt-F1 - F7] to a X session turns off
keyboard LEDs.
This issue is reproducible on 2:21.1.3-2ubuntu2.1 (on 22.04)
To reproduce:
1. Log on a X session desktop (GNOME Xorg for example)
2. Turn on NumLock
3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to switch back to desktop
Expected:
NumLock LED should be on
Actual:
NumLock LED is off, but functions like NumLock is on. If NumLock is pressed the LED turns off as well as the function. If CapsLock is pressed the LED states sync back (LED turns back on).
** Patch added: "xorg-server_21.1.3-2ubuntu2.8.debdiff"
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1993621/+attachment/5648795/+files/xorg-server_21.1.3-2ubuntu2.8.debdiff
** Summary changed:
- Force update keyboard LEDs after calling EnableDevice to fix its state after VT switching
+ Force update keyboard LEDs after calling EnableDevice to fix its hardware state after VT switching
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1993621
Title:
Force update keyboard LEDs after calling EnableDevice to fix its
hardware state after VT switching
Status in OEM Priority Project:
New
Status in X.Org X server:
New
Status in xorg-server package in Ubuntu:
New
Bug description:
[ Impact ]
* This change will force update keyboard LED status after calling
EnableDevice, in order to resolve LED status not syncing after
switching VT to a X session.
* This also fixes the issue with NVIDIA driver and Xorg, that after
resuming from suspend the keyboard LED is always off.
[ Test Plan ]
1. Log onto an GNOME session (KDE Kwin worked this issue around)
2. Turn on NumLock on the keyboard
3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to
switch back to desktop
NumLock LED should be on after switching back to the desktop
[ Where problems could occur ]
* The changes are to push status to the device when enabling it
regardless of actual keyboard state change, therefore switching
between VTs and adding/removing keyboard/mouse/xinput devices should
be affected by this change.
[ Original Report ]
Switching virtual terminals [Ctrl-Alt-F1 - F7] to a X session turns
off keyboard LEDs.
This issue is reproducible on 2:21.1.3-2ubuntu2.1 (on 22.04)
To reproduce:
1. Log on a X session desktop (GNOME Xorg for example)
2. Turn on NumLock
3. Use Ctrl-Alt-F3 to switch to a text console, then Ctrl-Alt-F2 to switch back to desktop
Expected:
NumLock LED should be on
Actual:
NumLock LED is off, but functions like NumLock is on. If NumLock is pressed the LED turns off as well as the function. If CapsLock is pressed the LED states sync back (LED turns back on).
To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1993621/+subscriptions
More information about the Ubuntu-sponsors
mailing list