[Bug 2046082] Re: zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

[Mauricio Faria de Oliveira]

Subscribing ~ubuntu-sponsors for review/sponsoring to Noble.
(I can handle the upload to mantic later.)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2046082

Title:
  zed.rc: typo in option ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT

Status in zfs-linux package in Ubuntu:
  Confirmed
Status in zfs-linux source package in Mantic:
  Confirmed
Status in zfs-linux source package in Noble:
  Confirmed

Bug description:
  [Impact]

   * There's a typo in user-visible option (/etc/zfs/zed.d/zed.rc)
     ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT introduced upstream
     in 2.2.0-rc4 and SRU-ed to Mantic with 2.2.0-0ubuntu1~23.10.

   * This could be fixed in Ubuntu before users start adopting it.

  [Test Plan]

   * Check whether /etc/zfs/zed.d/zed.rc ships the correct option.

   * Actual:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOUSRE_SLOT_ON_FAULT=1

   * Expected:
     $ grep ZED_POWER_OFF_ENCLO /etc/zfs/zed.d/zed.rc
     #ZED_POWER_OFF_ENCLOSURE_SLOT_ON_FAULT=1

  [Regression Potential]

   * Users of Mantic who upgraded to zfs-linux 2.2.0-0ubuntu1~23.10
     (published to mantic-updates on 2023-12-08) _and_ enabled the
     option (with typo) would have such functionality disabled.

  [Other Info]

   * This option (with typo) was introduced in commit d19304ffeec5
     ("zed: Add zedlet to power off slot when drive is faulted"),
     and is present in:
     - ZFS 2.2: zfs-2.2.0-rc4 (mantic-updates)
     - ZFS 2.1: zfs-2.1.13

   * It affects Ubuntu Noble and Mantic, but not Lunar or older.

   * Fixed upstream with commit 3c7650491b9a ("zed: fix typo in 
     variable ZED_POWER_OFF_ENCLO*US*RE_SLOT_ON_FAULT")

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2046082/+subscriptions