[Merge] ~mitchdz/ubuntu/+source/multipath-tools:mitch/mpathpersist-scsi-pg3-fix into ubuntu/+source/multipath-tools:ubuntu/jammy-devel

[Bryce Harrington]

Review: Approve

Removing the init scripts does strike me also as a bit bold for SRU, however I see this solution was proposed by an SRU admin member and seems to have been reviewed and discussed by the people who's opinion I'd rely on.  If there is more discussion needed on the appropriateness of this approach, those are also the people likely to do so as part of the SRU review.

https://bugs.launchpad.net/ubuntu/focal/+source/multipath-tools/+bug/2000186/comments/14

The other half of this upload is the fix for mpathpersist.  This took a bit of time to work through to understand the upstream patch but I spotted nothing to point out as incorrect.  Ideally I'd like to see a more detailed changelog entry for this, particularly since it's a fix to a regression caused by a CVE and thus admins and users may be more sensitive than normal.  However both the patch description and linked bug report are clear and informative, so it's not worth nitpicking on.

I've triggered tests against the PPA for the jammy and lunar packages.  I spot no issues there.  The test plan in the SRU bug description looks thorough.

* Results:
  - multipath-tools/0.8.8-1ubuntu1.22.04.2~jammy5
    + ✅ multipath-tools on jammy for amd64   @ 09.08.23 03:07:39  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for armhf   @ 09.08.23 02:17:28  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for ppc64el @ 09.08.23 02:26:11  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for s390x   @ 09.08.23 02:30:38  Log️ 🗒️ 
  - multipath-tools/0.8.8-1ubuntu2.1~lunar4
    + ✅ multipath-tools on lunar for amd64   @ 09.08.23 02:29:57  Log️ 🗒️ 
    + ✅ multipath-tools on lunar for armhf   @ 09.08.23 02:17:08  Log️ 🗒️ 
    + ✅ multipath-tools on lunar for ppc64el @ 09.08.23 02:28:35  Log️ 🗒️ 
  - multipath-tools/0.8.8-1ubuntu1.22.04.2~jammy5
    + ✅ multipath-tools on jammy for amd64   @ 09.08.23 03:07:39  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for armhf   @ 09.08.23 02:17:28  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for ppc64el @ 09.08.23 02:26:11  Log️ 🗒️ 
    + ✅ multipath-tools on jammy for s390x   @ 09.08.23 02:30:38  Log️ 🗒️ 
  - multipath-tools/0.8.8-1ubuntu2.1~lunar4
    + ✅ multipath-tools on lunar for amd64   @ 09.08.23 02:29:57  Log️ 🗒️ 
    + ✅ multipath-tools on lunar for armhf   @ 09.08.23 02:17:08  Log️ 🗒️ 
    + ✅ multipath-tools on lunar for ppc64el @ 09.08.23 02:28:35  Log️ 🗒️ 

I do have some changes to request for the SRU text but I'll make that a separate comment, as that is not a blocker for sponsoring the upload, which looks good, so,

Upload sponsored:

 fixup_buildinfo multipath-tools_0.8.8-1ubuntu1.22.04.2.dsc multipath-tools_0.8.8-1ubuntu1.22.04.2_source.buildinfo
 signfile buildinfo multipath-tools_0.8.8-1ubuntu1.22.04.2_source.buildinfo A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

 fixup_changes dsc multipath-tools_0.8.8-1ubuntu1.22.04.2.dsc multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes
 fixup_changes buildinfo multipath-tools_0.8.8-1ubuntu1.22.04.2_source.buildinfo multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes
 signfile changes multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

Successfully signed dsc, buildinfo, changes files

triage-jammy+22.04: ~/pkg/MultipathTools/review-lp2000186/multipath-tools-gu-jammy$ grep ^Vcs ../multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes
Vcs-Git: https://git.launchpad.net/~bryce/ubuntu/+source/multipath-tools
Vcs-Git-Commit: 017c4f2667ad2804d6a0e8fc530ca47584cee541
Vcs-Git-Ref: refs/heads/mpathpersist-scsi-pg3-fix-jammy
triage-jammy+22.04: ~/pkg/MultipathTools/review-lp2000186/multipath-tools-gu-jammy$ dput ubuntu ../multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: ../multipath-tools_0.8.8-1ubuntu1.22.04.2.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading multipath-tools_0.8.8-1ubuntu1.22.04.2.dsc: done.
  Uploading multipath-tools_0.8.8-1ubuntu1.22.04.2.debian.tar.xz: done.  
  Uploading multipath-tools_0.8.8-1ubuntu1.22.04.2_source.buildinfo: done.
  Uploading multipath-tools_0.8.8-1ubuntu1.22.04.2_source.changes: done.
Successfully uploaded packages.

-- 
https://code.launchpad.net/~mitchdz/ubuntu/+source/multipath-tools/+git/multipath-tools/+merge/446796
Your team Ubuntu Sponsors is requested to review the proposed merge of ~mitchdz/ubuntu/+source/multipath-tools:mitch/mpathpersist-scsi-pg3-fix into ubuntu/+source/multipath-tools:ubuntu/jammy-devel.