[Bug 2029952] Re: [SRU] backport msgpack max_buffer_size patch to Focal

[Robie Basak]

> [Where problems could occur]

FTR, I was concerned about any OOM type conditions that might be
introduced especially if controllable by a third party, but I saw this
in the patch description:

> Also, since `msgpack` is only being used by the internal API, we're
not worried about a third party coming in and overwhelming the system by
deserializing calls.

However https://bugs.launchpad.net/ubuntu/+source/python-
oslo.privsep/+bug/1896734/comments/37 talks of large number of ports. Is
there any similar "large numbers" situation in which this change might
introduce an OOM condition in practice, when it didn't before?

Accepting regardless - that's just something to look out for in
consideration of testing. If you think it can't occur then it's fine :)

** Changed in: python-oslo.privsep (Ubuntu Jammy)
       Status: Triaged => Fix Committed

** Tags added: verification-needed verification-needed-jammy

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2029952

Title:
  [SRU] backport msgpack max_buffer_size patch to Focal

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive ussuri series:
  Triaged
Status in Ubuntu Cloud Archive victoria series:
  Fix Committed
Status in Ubuntu Cloud Archive wallaby series:
  Fix Committed
Status in Ubuntu Cloud Archive xena series:
  Fix Committed
Status in Ubuntu Cloud Archive yoga series:
  Triaged
Status in python-oslo.privsep package in Ubuntu:
  Fix Released
Status in python-oslo.privsep source package in Focal:
  Fix Committed
Status in python-oslo.privsep source package in Jammy:
  Fix Committed

Bug description:
  [Impact]
  Hosts running Openstack Neutron from Ussuri to Yoga release are impacted by
  the fact that their use of oslo.privsep is thwarted by a default buffer size
  on python-msgpack such that commands that return strings > 1MB in size cause
  privsep to crash and agents to stop working. This patch backports a fix that
  increased the buffer size to one that is more appropriate to neutron usage.

  [Test Plan]

    * deploy Openstack (version corresponding to release of SRU) with l3ha
    * need at least one compute host and two neutron-gateway hosts
    * create a large number of routers each with several networks attached
    * restart neutron-l3-agent
    * wait for restart to complete then do 'journalctl --unit neutron-l3-agent --grep ValueError'
    * if the error does not appear then the patch is working
    * note that it is necessary to create routers with enough networks and ports to trigger the > 1MB size limit for the netlink info message returned by privsep to trigger

  [Where problems could occur]
  No regressions are expected to occur as a result of this patch as it is
  increasing the buffer size by a fairly small amount to allow neutron
  function correctly in loaded environments.

  --------------------------------------------------------------------------------

  The main explanation for this backport can be found in
  https://bugs.launchpad.net/ubuntu/+source/python-
  oslo.privsep/+bug/1896734/comments/37 but I'm opening a new bug for
  the privsep backport since 1896734 was used to backport a neutron fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2029952/+subscriptions