[Bug 2012407] Re: ipu6-drivers module should not try to build when CONFIG_I2C is disabled

Fri Apr 14 12:32:53 UTC 2023

This is needed for kinetic too.
I attached the debdiff.

Tested on a local vm:
ubuntu at kinetic:~/ipu6-drivers$ sudo dpkg -i intel-ipu6-dkms_0~git202211220708.278b7e3d-0ubuntu0.22.10.2_amd64.deb
Selecting previously unselected package intel-ipu6-dkms.
(Reading database ... 135914 files and directories currently installed.)
Preparing to unpack intel-ipu6-dkms_0~git202211220708.278b7e3d-0ubuntu0.22.10.2_amd64.deb ...
Unpacking intel-ipu6-dkms (0~git202211220708.278b7e3d-0ubuntu0.22.10.2) ...
Setting up intel-ipu6-dkms (0~git202211220708.278b7e3d-0ubuntu0.22.10.2) ...
Loading new ipu6-drivers-0~git202211220708.278b7e3d-0ubuntu0.22.10.2 DKMS files...
Building for 5.19.0-1021-kvm
Building initial module for 5.19.0-1021-kvm
Error! The /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.10.2/5.19.0-1021-kvm/x86_64/dkms.conf for module ipu6-drivers includes a BUILD_EXCLUSIVE directive which does not match this kernel/arch/config.
This indicates that it should not be built.
Skipped.
ubuntu at kinetic:~/ipu6-drivers$

** Patch added: "ipu6-drivers-kinetic.debdiff"
   https://bugs.launchpad.net/ubuntu/jammy/+source/ipu6-drivers/+bug/2012407/+attachment/5664014/+files/ipu6-drivers-kinetic.debdiff

** Also affects: ipu6-drivers (Ubuntu Kinetic)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/2012407

Title:
  ipu6-drivers module should not try to build when CONFIG_I2C is
  disabled

Status in ipu6-drivers package in Ubuntu:
  New
Status in ipu6-drivers source package in Jammy:
  New
Status in ipu6-drivers source package in Kinetic:
  New

Bug description:
  SRU justification:

  [Impact]

  This is encountered on linux kernel derivatives with fewer configuration options enabled.
  First time seen on jammy:linux-kvm-1029.

  During build, it fails with the following error:
  ...
  Building module:
  cleaning build area...
  make -j1 KERNELRELEASE=5.15.0-1030-kvm KERNELRELEASE=5.15.0-1030-kvm KERNEL_SRC=/lib/modules/5.15.0-1030-kvm/build...........(bad exit status: 2)
  Error! Bad return status for module build on kernel: 5.15.0-1030-kvm (x86_64)
  Consult /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/make.log for more information.
  E: ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1 failed to build for 5.15.0-1030-kvm
  ========== /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/make.log ==========
  DKMS make.log for ipu6-drivers-0~git202211220708.278b7e3d-0ubuntu0.22.04.1 for kernel 5.15.0-1030-kvm (x86_64)
  Wed Mar  8 23:42:18 UTC 2023
  make -C /lib/modules/5.15.0-1030-kvm/build M=/var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build modules
  make[1]: Entering directory '/usr/src/linux-headers-5.15.0-1030-kvm'
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-bus.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-dma.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-mmu.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-buttress.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-trace.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-cpd.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/ipu6.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-fw-com.o
    CC [M]  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-isys-bridge.o
  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-isys-bridge.c: In function ‘ipu_isys_bridge_unregister_sensors’:
  /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-isys-bridge.c:283:17: error: implicit declaration of function ‘i2c_unregister_device’; did you mean ‘pci_unregister_driver’? [-Werror=implicit-function-declaration]
    283 |                 i2c_unregister_device(sensor->vcm_i2c_client);
        |                 ^~~~~~~~~~~~~~~~~~~~~
        |                 pci_unregister_driver
  cc1: some warnings being treated as errors
  make[4]: *** [scripts/Makefile.build:297: /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6/../ipu-isys-bridge.o] Error 1
  make[3]: *** [scripts/Makefile.build:560: /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel/ipu6] Error 2
  make[2]: *** [scripts/Makefile.build:560: /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/drivers/media/pci/intel] Error 2
  make[1]: *** [Makefile:1906: /var/lib/dkms/ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build] Error 2
  make[1]: Leaving directory '/usr/src/linux-headers-5.15.0-1030-kvm'
  make: *** [Makefile:37: all] Error 2
  ====================
  ./ipu6-drivers/0~git202211220708.278b7e3d-0ubuntu0.22.04.1/build/make.log
  autopkgtest [23:42:45]: test dkms-autopkgtest: -----------------------]
  autopkgtest [23:42:46]: test dkms-autopkgtest:  - - - - - - - - - - results - - - - - - - - - -
  dkms-autopkgtest     FAIL non-zero exit status 1
  autopkgtest [23:42:46]: @@@@@@@@@@@@@@@@@@@@ summary

  because CONFIG_I2C=n

  [Fix]
  Add a rule to avoid building ipu6-drivers when CONFIG_I2C=n

  [Test Plan]
  Install a new version of jammy:linux-kvm (1029 for example).
  apt install ipu6-drivers will fail as described above.
  After the fix, it will not built at all.

  Once the package is in proposed, a new adt is triggered against
  proposed for jammy:linux-kvm.

  [Where problems could occur]
  Low possibility of new issues.

  [Note]
  This fix is not scalable in the sense that if configuration name changes, the module has to be changed as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ipu6-drivers/+bug/2012407/+subscriptions