[Bug 1965174] Re: pktstat FTBFS: error: format not a string literal and no format arguments [-Werror=format-security]

[Nick Rosbrook]

** Patch added: "pktstat-lp-1965174.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/pktstat/+bug/1965174/+attachment/5570560/+files/pktstat-lp-1965174.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1965174

Title:
  pktstat FTBFS: error: format not a string literal and no format
  arguments [-Werror=format-security]

Status in pktstat package in Ubuntu:
  Fix Committed
Status in pktstat package in Debian:
  Fix Committed

Bug description:
  Imported from Debian bug http://bugs.debian.org/995624:

  Source: pktstat
  Version: 1.8.5-7
  Severity: serious
  Tags: ftbfs

  pktstat fails to build from source in unstable on amd64. A non-parallel
  build ends as follows:

  | gcc -DHAVE_CONFIG_H -I.  -DPATH_PKTSTATRC=\"/etc/pktstatrc\" -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -D_BSD_SOURCE -c -o display.o display.c
  | In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
  |                  from /usr/include/stdio.h:27,
  |                  from display.c:17:
  | /usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  |   187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
  |       |   ^~~~~~~
  | display.c: In function ‘display_update’:
  | display.c:499:33: warning: field width specifier ‘*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
  |   499 |  attron(A_UNDERLINE); printw("%-*s",
  |       |                               ~~^~
  |       |                                 |
  |       |                                 int
  | display.c:552:13: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
  |   552 |   printw("%.*s\n", MIN(maxx - LLEN, sizeof flows[i].tag - 1),
  |       |           ~~^~
  |       |             |
  |       |             int
  | display.c:566:15: warning: field precision specifier ‘.*’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Wformat=]
  |   566 |    printw(" %.*s\n", MIN(maxx - LLEN - 2,
  |       |             ~~^~
  |       |               |
  |       |               int
  | display.c:285:21: warning: variable ‘x’ set but not used [-Wunused-but-set-variable]
  |   285 |  int maxx, maxy, y, x;
  |       |                     ^
  | display.c: In function ‘printhelp’:
  | display.c:672:3: error: format not a string literal and no format arguments [-Werror=format-security]
  |   672 |   printw((char *)h->name + 1);
  |       |   ^~~~~~
  | cc1: some warnings being treated as errors
  | make[2]: *** [Makefile:483: display.o] Error 1
  | make[2]: Leaving directory '/<<PKGBUILDDIR>>'
  | make[1]: *** [Makefile:339: all] Error 2
  | make[1]: Leaving directory '/<<PKGBUILDDIR>>'
  | dh_auto_build: error: make -j1 returned exit code 2
  | make: *** [debian/rules:11: build] Error 25
  | dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

  This is likely due to ncurses including format string annotations.

  Helmut

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pktstat/+bug/1965174/+subscriptions