[Bug 1852610] [NEW] [SRU] API allows source compute service/node deletion while instances are pending a resize confirm/revert

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[Impact]

 * API will allow deleting a source compute service which has migration-
based allocations for the source node resource provider and pending
instance resizes involving the source node.

 * Backporting the fix will improve application resilience in this case.

[Test Case]

 1. create a server on host1
 2. resize or cold migrate it to a dest host2
 3. delete the compute service for host1

 At this point the resource provider for host1 is orphaned.

 4. try to confirm/revert the resize of the server which will fail
because the compute node for host1 is gone and this results in the
server going to ERROR status

[Where problems could occur]

 * This change introduces an exception condition in the API and prevents
the erroneous deletion of compute services which would result in
orphaned state.

 * As such we should expect to see altered behavior from the API as
detailed in api-ref/source/os-services.inc

 * If problems were to occur they would manifest in behavior that is
different from both the original behavior of the API and the new
behavior.

--- Original Description ---
This is split off from bug 1829479 which is about deleting a compute service which had servers evacuated from it which will orphan resource providers in placement.

A similar scenario is true where the API will allow deleting a source
compute service which has migration-based allocations for the source
node resource provider and pending instance resizes involving the source
node. A  simple scenario is:

1. create a server on host1
2. resize or cold migrate it to a dest host2
3. delete the compute service for host1

At this point the resource provider for host1 is orphaned.

4. try to confirm/revert the resize of the server which will fail
because the compute node for host1 is gone and this results in the
server going to ERROR status

Based on the discussion in this mailing list thread:

http://lists.openstack.org/pipermail/openstack-
discuss/2019-November/010843.html

We should probably have the DELETE /os-services/{service_id} API block
trying to delete a service that has pending migrations.

** Affects: cloud-archive
     Importance: Undecided
         Status: New

** Affects: cloud-archive/queens
     Importance: Undecided
     Assignee: Brett Milford (brettmilford)
         Status: In Progress

** Affects: nova
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Fix Released

** Affects: nova/queens
     Importance: Low
     Assignee: Lee Yarwood (lyarwood)
         Status: Fix Committed

** Affects: nova/rocky
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Fix Committed

** Affects: nova/stein
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Fix Committed

** Affects: nova/train
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Fix Committed

** Affects: nova (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: nova (Ubuntu Bionic)
     Importance: Undecided
     Assignee: Brett Milford (brettmilford)
         Status: In Progress


** Tags: api in-stable-queens in-stable-rocky in-stable-stein in-stable-train patch placement resize sru-needed sts
-- 
[SRU] API allows source compute service/node deletion while instances are pending a resize confirm/revert
https://bugs.launchpad.net/bugs/1852610
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.