[Bug 1956264] Re: Cannot set offload options to false

[Lukas Märdian]

Thank you very much! I left some comments inside the merge-proposal.

Please also adopt the description of this bug report according to the
SRU template in
https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template,
describing a proper test case/reporducer and impact analysis, to make it
fit for SRU.

** Changed in: netplan.io (Ubuntu Jammy)
       Status: New => In Progress

** Changed in: netplan.io (Ubuntu Jammy)
     Assignee: (unassigned) => Nicolas Bock (nicolasbock)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1956264

Title:
  Cannot set offload options to false

Status in netplan:
  Fix Committed
Status in netplan.io package in Ubuntu:
  Fix Released
Status in netplan.io source package in Focal:
  New
Status in netplan.io source package in Impish:
  New
Status in netplan.io source package in Jammy:
  In Progress
Status in netplan.io source package in Kinetic:
  Fix Released

Bug description:
  In https://bugs.launchpad.net/netplan/+bug/1771740, the ability to set
  the offload options that are exposed by systemd.link was added.
  Unfortunately, the implementation only allows setting the offload
  options to true. Setting the options to false results in nothing being
  written to the generated .link file, because "false" is treated the
  same as "unset" by netplan.

  See the current implementation
  https://git.launchpad.net/netplan/tree/src/networkd.c#n260.

  netplan needs to handle three different values for the offload
  options: "true", "false", and "unset"

  (I have a specific case in mind,
  https://bugzilla.kernel.org/show_bug.cgi?id=118721, where I need to
  set TSO to off when using the e1000e driver. The current netplan
  implementation does not support that; as a workaround I created a
  separate .link file in /etc/systemd/network to disable TSO.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1956264/+subscriptions