[Bug 1960814] Re: Sync tigervnc 1.12.0+dfsg-2 (universe) from Debian unstable (main)

[Christian Ehrhardt ]

I agree that our old delta is in Debian, we are also not yet in feature
freeze so syncing this should be fine.

I see https://launchpad.net/ubuntu/+source/tigervnc/1.12.0+dfsg-2 appeared and builds.
I'll let syncpkg do its post and set it back to fix committed.

@Frank - please guide the proposed migration of this and set to fix-
released once fully migrated.

** Changed in: tigervnc (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1960814

Title:
  Sync tigervnc 1.12.0+dfsg-2 (universe) from Debian unstable (main)

Status in Ubuntu on IBM z Systems:
  New
Status in tigervnc package in Ubuntu:
  Fix Committed

Bug description:
  Please sync tigervnc 1.12.0+dfsg-2 (universe) from Debian unstable
  (main)

  Explanation of the Ubuntu delta and why it can be dropped:
    * debian/patch/0001-Update-Surface_X11.cxx.patch
      TigerVNC 1.11.0 contains a regression that causes vncviewer to display
      incorrect colors when vncviewer and X11 server use different endianness.
      (LP: #1929790)

  A while ago I worked on the following bug:
  "Request to backport fix for endianness issue in TigerVNC vncviewer"
  https://bugs.launchpad.net/bugs/1929790
  "
  tigervnc (1.11.0+dfsg-2ubuntu1) impish; urgency=medium

    * debian/patch/0001-Update-Surface_X11.cxx.patch
      TigerVNC 1.11.0 contains a regression that causes vncviewer to display
      incorrect colors when vncviewer and X11 server use different endianness.
      (LP: #1929790)

   -- Frank Heimes <frank.heimes at canonical.com>  Mon, 20 Sep 2021 19:57:36 +0200
  "
  and it was eventually fixed for hirsute and impish with v1.11.0+dfsg-2ubuntu1,
  based on picking an upstream commit (7ab92639848) to v1.11.
  This commit (transferred into a quilt patch: 0001-Update-Surface_X11.cxx.patch)
  was the one and only delta between Debian and Ubuntu.

  So it was highly likely that once a new upstream release is picked up by Debian,
  this would possibly replace the Ubuntu specific version based on a sync.

  MoM lists that new package:
  https://merges.ubuntu.com/universe.html?query=tigervnc&showProposed=true&showMergeNeeded=true
  for obvious reasons as modified.

  I had a look at the patches and like assumed the only delta was
  quilt patch '0001-Update-Surface_X11.cxx.patch'.
  This patch didn't applied anymore (which is expected).
  Looking at the code in v1.12 and upstream git tells my (like expected)
  that the fix is now included in v.1.12:
  $ git log --oneline --grep "Runtime sellection of ARGB  XImage byte order"
  7ab92639 Update Surface_X11.cxx
  $ git tag --contains 7ab92639
  v1.11.90
  v1.12.0
  So I can explicitly confirm that the Ubuntu changes can safely be overridden.

  
  Changelog entries since current jammy version 1.11.0+dfsg-2ubuntu1:

  tigervnc (1.12.0+dfsg-2) unstable; urgency=medium

    * Re-upload as-is (and source-only).

   -- Mike Gabriel <sunweaver at debian.org>  Sun, 30 Jan 2022 17:40:52
  +0100

  tigervnc (1.12.0+dfsg-1) unstable; urgency=medium

    [ Joachim Falk ]
    * Fresh upstream TigerVNC 1.12.0 (Closes: #880587, #879866, #855350)
    * Updated app stream org.tigervnc.xtigervncviewer.metainfo.xml information
      file for TigerVNC 1.12.0 release.
    * Adjusted options for tigervncserver and x0tigervncserver to correspond to
      TigerVNC 1.12.0 release.
    * Correctly initialize XDG_SESSION_DESKTOP, XDG_CURRENT_DESKTOP,
      XDG_SESSION_TYPE, and XDG_SESSION_CLASS.
    * Refreshed copyright years and bumped version of man pages.
    * Small content tweak in tigervnc.conf.5x (rfbwait option no longer exists).
    * Split of tigervncpasswd from tigervnc-common into its own tigervnc-tools
      package.
    * Fixed some lintian errors.
    * Bumped Standards-Version: to 4.6.0. No changes were needed.
    * Fixed typo in tigervncserver man page. (Closes: #1003715)
    * Clear session argument from config file if -xstartup specified on the
      command line. (Closes: #1000871)
    * Fixed tigervncserver/x0tigervncserver -list for VNC servers not using a
      rfbport from 5900 to 5999. (Closes: #1004365)
    * Support for -rfbunixpath in tigervncserver and x0tigervncserver wrapper
      scripts. (LP: #1892595)
    * Fixed gnome desktop start up when using tigervncserver at .service.
      (Closes: #1004395)
    * Provided example configuration for tigervnc-xorg-extension. However, this
      is still broken due to bug #855441.
    * Applied the following upstream fixes:
      - a6160b Fix formatting of -rfbport in man pages
      - 2daf41 Fix typo in mirror monitor detection
      - 1a729d Fix handling of VMware cursors
      - 88e96d Fix session resize after mirroring on Linux vncviewer

   -- Joachim Falk <joachim.falk at gmx.de>  Wed, 26 Jan 2022 18:19:38
  +0100

  tigervnc (1.11.0+dfsg-3) unstable; urgency=medium

    [ Joachim Falk ]
    * Fixed warnings use of uninitialized value in string eq at
      /usr/share/perl5/TigerVNC/Config.pm line 401 or 414. (Closes: #1004366)
    * Fixed debian/watch to again detect upstream versions.
    * Bumped Standards-Version: to 4.5.1. No changes needed.
    * Added org.tigervnc.xtigervncviewer.metainfo.xml for appstream

   -- Joachim Falk <joachim.falk at gmx.de>  Sat, 17 Apr 2021 10:22:50
  +0200

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1960814/+subscriptions