[Merge] ~macg3/ubuntu/+source/gdebi:fix_pkexec into ubuntu/+source/gdebi:ubuntu/devel

[Robie Basak]

You have been requested to review the proposed merge of ~macg3/ubuntu/+source/gdebi:fix_pkexec into ubuntu/+source/gdebi:ubuntu/devel.

For more details, see:
https://code.launchpad.net/~macg3/ubuntu/+source/gdebi/+git/gdebi/+merge/414211

This fixes a longstanding issue that prevents GDebi from working properly when it is launched by a GUI app, such as Firefox or Chrome after downloading a deb file. Ever since Ubuntu 17.10, GDebi just quits immediately when you click Install. It works properly when you run it from a terminal window, but not when launched from Firefox or Chrome. The reason is because pkexec refuses to work if its parent process is init. This change adds an intermediate script that acts as the parent for pkexec.

To test:

- Download a deb file in Firefox/Chrome.
- Open it from within the browser's downloads screen, and choose to open it with GDebi.
- It will open fine. Now, click Install.

Without this change applied, GDebi will immediately quit and the package won't be installed.
After this change is applied, GDebi will successfully install the package.

Another way to test is by directly running GDebi with setsid:

setsid gdebi-gtk package.deb

Without this change, it will fail in the same way. With this change, it will succeed.

The bug that this fixes is Launchpad #1854588. Ideally this would be ported to all of the LTS releases. I'm brand new to this Launchpad workflow, so I'm not sure if there's anything I need to do in order to kickstart this process.

-- 
Your team Ubuntu Sponsors Team is requested to review the proposed merge of ~macg3/ubuntu/+source/gdebi:fix_pkexec into ubuntu/+source/gdebi:ubuntu/devel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2377 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20221206/b54b69ee/attachment-0001.diff>