[Bug 1969227] Re: scilab 6.1.1+dfsg2-3 fail to build

[Graham Inggs]

** Changed in: scilab (Ubuntu)
     Assignee: (unassigned) => Graham Inggs (ginggs)

** Changed in: scilab (Ubuntu)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1969227

Title:
  scilab 6.1.1+dfsg2-3 fail to build

Status in scilab package in Ubuntu:
  In Progress

Bug description:
  scilab 6.1.1+dfsg2-3 was uploaded on Nov 11 2021 and has failed to
  build ever since

  https://launchpad.net/ubuntu/+source/scilab/6.1.1+dfsg2-3/+build/22400494

  https://launchpadlibrarian.net/596601979/buildlog_ubuntu-jammy-
  amd64.scilab_6.1.1+dfsg2-3_BUILDING.txt.gz

  Here is the build error
  ../../modules/core/includes/pause.h:18:18: error: conflicting declaration of C function ‘void pause()’
     18 | CORE_IMPEXP void pause(void);
        |                  ^~~~~
  In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                   from /usr/include/signal.h:328,
                   from ../../modules/threads/includes/Thread_Wrapper.h:53,
                   from ../../modules/ast/includes/system_env/threadmanagement.hxx:21,
                   from src/cpp/pause.cpp:15:
  /usr/include/unistd.h:489:12: note: previous declaration ‘int pause()’
    489 | extern int pause (void);
        |            ^~~~~
  src/cpp/pause.cpp:22:6: error: ambiguating new declaration of ‘void pause()’
     22 | void pause(void)
        |      ^~~~~
  In file included from /usr/include/x86_64-linux-gnu/bits/sigstksz.h:24,
                   from /usr/include/signal.h:328,
                   from ../../modules/threads/includes/Thread_Wrapper.h:53,
                   from ../../modules/ast/includes/system_env/threadmanagement.hxx:21,
                   from src/cpp/pause.cpp:15:
  /usr/include/unistd.h:489:12: note: old declaration ‘int pause()’
    489 | extern int pause (void);
        |            ^~~~~

  It appears scilab core module has a function called pause that
  conflicts with the standard unistd pause function.

  I made a patch that allow scilab to build and I tested from my ppa.
  This patch simply rename the function to scipause. This doesn't feel very elegant and there might be a better solution. I'll leave it up to more experience folks to decide if this needs rework :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/scilab/+bug/1969227/+subscriptions