[Bug 1944475] Re: DistUpgradeViewNonInteractive is now interactive

[Bryce Harrington]

Thanks, the hirsute changes LGTM, I've sponsored the upload for SRU.

The changes appear to already be uploaded for impish in version
1:21.10.8, and has transitioned into -release so I gather the impish bug
task can be marked fixed.

I also verified the test case in the SRU template on a hirsute LXC
container, and worked exactly as written.  Rest of the SRU text also
looks good.

** Changed in: ubuntu-release-upgrader (Ubuntu Hirsute)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1944475

Title:
  DistUpgradeViewNonInteractive is now interactive

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Hirsute:
  Fix Committed
Status in ubuntu-release-upgrader source package in Impish:
  Fix Released

Bug description:
  [Impact]
    * The non-interactive release upgrades ask a question and wait for
      an interaction from the user. This makes the "NonInteractive"
      process interactive, and therefore breaks automatic upgrades.

  [Test Case]
    * On a hirsute VM, make sure all packages are up to date
      by running `sudo apt update && sudo apt upgrade -y`
    * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
    * Observe that the the upgrader displays the release notes followed
      by a question in the form of "Continue [yN]"
    * Type N and press enter to cancel the upgrade
    * Install ubuntu-release-upgrader from hirsute-proposed
    * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
    * Observe that the release upgrade completes successfully without
      any interaction from the user.

  [Regression Potential]
    * If the check for the specific frontend is not
      properly written it may be possible that
      the other frontends no longer display the release
      notes and ask the user if they want to continue.
    * This can be tested by running "do-release-upgrade"
      with --frontend=DistUpgradeViewGtk3 and
      --frontend=DistUpgradeViewText and verifying that
      the question is asked.

  [Original Description]
  With the change to show the release notes when using the "Text" view of the release upgrader (LP: #1925529) a yes / no question regarding upgrading is also displayed when using the NonInteractive view. This ends up making the upgrade process interactive and breaks automatic upgrade testing as seen in this log file:

  == More Information ==

  You can find out more about Ubuntu on the Ubuntu website and Ubuntu
  wiki.

    http://www.ubuntu.com/
    http://wiki.ubuntu.com/

  To sign up for Ubuntu development announcements, please
  subscribe to Ubuntu's development announcement list at:

    http://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-announce

  Continue [yN] auto-upgrade [13:48:19]: Rebooting the system.
  bash: line 1:   889 Killed                  /tmp/autopkgtest.u4eodP/build.JbM/real-tree/debian/tests/upgrade 2> >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stderr >&2) > >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stdout)
  autopkgtest: DBG: testbed command exited with code 137

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1944475/+subscriptions