[Bug 1944475] [NEW] DistUpgradeViewNonInteractive is now interactive

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[Impact]
  * The non-interactive release upgrades ask a question and wait for
    an interaction from the user. This makes the "NonInteractive"
    process interactive, and therefore breaks automatic upgrades.

[Test Case]
  * On a hirsute VM, make sure all packages are up to date
    by running `sudo apt update && sudo apt upgrade -y`
  * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
  * Observe that the the upgrader displays the release notes followed
    by a question in the form of "Continue [yN]"
  * Type N and press enter to cancel the upgrade
  * Install ubuntu-release-upgrader from hirsute-proposed
  * `sudo do-release-upgrade -d --frontend=DistUpgradeViewNonInteractive`
  * Observe that the release upgrade completes successfully without
    any interaction from the user.

[Regression Potential]
  * If the check for the specific frontend is not
    properly written it may be possible that
    the other frontends no longer display the release
    notes and ask the user if they want to continue.
  * This can be tested by running "do-release-upgrade"
    with --frontend=DistUpgradeViewGtk3 and
    --frontend=DistUpgradeViewText and verifying that
    the question is asked.

[Original Description]
With the change to show the release notes when using the "Text" view of the release upgrader (LP: #1925529) a yes / no question regarding upgrading is also displayed when using the NonInteractive view. This ends up making the upgrade process interactive and breaks automatic upgrade testing as seen in this log file:

== More Information ==

You can find out more about Ubuntu on the Ubuntu website and Ubuntu
wiki.

  http://www.ubuntu.com/
  http://wiki.ubuntu.com/

To sign up for Ubuntu development announcements, please
subscribe to Ubuntu's development announcement list at:

  http://lists.ubuntu.com/mailman/listinfo/ubuntu-devel-announce

Continue [yN] auto-upgrade [13:48:19]: Rebooting the system.
bash: line 1:   889 Killed                  /tmp/autopkgtest.u4eodP/build.JbM/real-tree/debian/tests/upgrade 2> >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stderr >&2) > >(tee -a /tmp/autopkgtest.u4eodP/upgrade-stdout)
autopkgtest: DBG: testbed command exited with code 137

** Affects: ubuntu-release-upgrader (Ubuntu)
     Importance: High
     Assignee: Brian Murray (brian-murray)
         Status: In Progress

** Affects: ubuntu-release-upgrader (Ubuntu Hirsute)
     Importance: Undecided
     Assignee: William Wilson (jawn-smith)
         Status: In Progress

** Affects: ubuntu-release-upgrader (Ubuntu Impish)
     Importance: High
     Assignee: Brian Murray (brian-murray)
         Status: In Progress


** Tags: fr-1741 hirsute impish iso-testing patch verification-needed-hirsute
-- 
DistUpgradeViewNonInteractive is now interactive
https://bugs.launchpad.net/bugs/1944475
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.