[Bug 1944741] Re: HiFive Unmatched partitions are named "Unleashed"

Tue Oct 12 15:05:21 UTC 2021

Thank you! You changes LGTM.
The first patch resembles the upstream commit, the 2nd patch (that touches the translation files) is not yet merged upstream, but makes sense.

With all builds passing in a PPA and a successful autopkgtest run, I'll
stage this to be a 0-day SRU, as discussed with the release team.

$ dput ubuntu ../util-linux_2.36.1-8ubuntu2_source.changes 
D: Setting host argument.
Checking signature on .changes
gpg: ../util-linux_2.36.1-8ubuntu2_source.changes: Valid signature from 5889C17AB1C8D890
Checking signature on .dsc
gpg: ../util-linux_2.36.1-8ubuntu2.dsc: Valid signature from 5889C17AB1C8D890
Uploading to ubuntu (via sftp to upload.ubuntu.com):
  Uploading util-linux_2.36.1-8ubuntu2.dsc: done.
  Uploading util-linux_2.36.1-8ubuntu2.debian.tar.xz: done.    
  Uploading util-linux_2.36.1-8ubuntu2_source.buildinfo: done. 
  Uploading util-linux_2.36.1-8ubuntu2_source.changes: done.
Successfully uploaded packages.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1944741

Title:
  HiFive Unmatched partitions are named "Unleashed"

Status in util-linux package in Ubuntu:
  New
Status in util-linux source package in Impish:
  New
Status in util-linux package in Debian:
  Confirmed

Bug description:
  [Impact]                                                                         

  Both HiFive Unleashed and HiFive Unmatched bootloaders seek for the same         
  UUIDs to load the next stage bootloader: the current name makes partitions       
  on Unmatched board appear as 'Unleashed'.                                        

  This issue gives the feeling that the Ubuntu RISC-V images made specifically     
  for those 2 boards were assembled in a rushed manner.                            

  The attached patch fixes this by removing the 'Unleashed' part of the current    
  name so that it fits both, it was build againt all architectures here:           
  https://launchpad.net/~alexghiti/+archive/ubuntu/riscv/+sourcepub/12783067/+listing-archive-extra

  [Test Plan]                                                                      

  1. Download the SiFive Unmatched image here: https://cdimage.ubuntu.com/ubuntu-server/daily-preinstalled/pending/impish-preinstalled-server-riscv64+unmatched.img.xz
  2. Follow instructions here to launch a riscv64 VM: https://wiki.ubuntu.com/RISC-V
  3. Execute the following command:                                                
          ubuntu at ubuntu:~$ sudo fdisk -l                                           
          Disk /dev/vda: 40 GiB, 42949672960 bytes, 83886080 sectors               
          Units: sectors of 1 * 512 = 512 bytes                                    
          Sector size (logical/physical): 512 bytes / 512 bytes                    
          I/O size (minimum/optimal): 512 bytes / 512 bytes                        
          Disklabel type: gpt                                                      
          Disk identifier: 0F66C0C3-A5E4-439B-907E-ABAD106FE4A7                    

          Device      Start      End  Sectors  Size Type                           
          /dev/vda1  235554 83886046 83650493 39.9G Linux filesystem               
          /dev/vda12 227362   235553     8192    4M Linux filesystem               
          /dev/vda13     34     2081     2048    1M HiFive Unleashed FSBL          
          /dev/vda14   2082    10273     8192    4M HiFive Unleashed BBL           
          /dev/vda15  10274   227361   217088  106M EFI System                     

          Partition table entries are not in disk order.                           
  4. Download and install the new packages that contain the fix here:              
          https://launchpad.net/~alexghiti/+archive/ubuntu/riscv/+files/libfdisk1_2.36.1-8ubuntu4_riscv64.deb
          https://launchpad.net/~alexghiti/+archive/ubuntu/riscv/+files/libfdisk-dev_2.36.1-8ubuntu4_riscv64.deb
          https://launchpad.net/~alexghiti/+archive/ubuntu/riscv/+files/fdisk_2.36.1-8ubuntu4_riscv64.deb
  5. Re-execute the same command as above:                                         
          ubuntu at ubuntu:~$ sudo fdisk -l                                           
          Disk /dev/vda: 40 GiB, 42949672960 bytes, 83886080 sectors               
          Units: sectors of 1 * 512 = 512 bytes                                    
          Sector size (logical/physical): 512 bytes / 512 bytes                    
          I/O size (minimum/optimal): 512 bytes / 512 bytes                        
          Disklabel type: gpt                                                      
          Disk identifier: 0F66C0C3-A5E4-439B-907E-ABAD106FE4A7                    

          Device      Start      End  Sectors  Size Type                           
          /dev/vda1  235554 83886046 83650493 39.9G Linux filesystem               
          /dev/vda12 227362   235553     8192    4M Linux filesystem               
          /dev/vda13     34     2081     2048    1M HiFive FSBL                    
          /dev/vda14   2082    10273     8192    4M HiFive BBL                     
          /dev/vda15  10274   227361   217088  106M EFI System                     

          Partition table entries are not in disk order.                           

  [Where problems could occur]                                                     

  We may expect regressions if one uses fdisk output (ie the partition names       
  instead of the UUIDs) in her software: this risk is mitigated by the fact the    
  upstream accepted the patch and then does not expect this interface to be        
  immutable and that RISC-V is not widely used yet.                                

  [Other Info]                                                                     

  None.                                                                            

  === old bug description ===                                                      
  Both HiFive Unleashed and HiFive Unmatched bootloaders seek for the same         
  UUIDs to load the next stage bootloader: the current name makes partitions       
  on Unmatched board appear as 'Unleashed'.                                        

  Fix that by removing the 'Unleashed' part of the current name so that it         
  fits both.                                                                       

  The attached debdiff contains the patch that was merged upstream (https://github.com/karelzak/util-linux/commit/10fd91d389497d8be435cc66abbdeb2eb6ea2f07).
  ~

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1944741/+subscriptions