[Bug 1935849] Re: [SRU] Reenabling toolbar in two-pane view causes the toolbar on each pane to think its two separate nemo main toolbars

[Brian Murray]

Sponsored, thanks for the debdiff.

 $ dput nemo_4.4.2-2ubuntu2_source.changes 
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /tmp/pkgs/focal/nemo_4.4.2-2ubuntu2_source.changes: Valid signature from 1E918B66765B3E31
Checking signature on .dsc
gpg: /tmp/pkgs/focal/nemo_4.4.2-2ubuntu2.dsc: Valid signature from 1E918B66765B3E31
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading nemo_4.4.2-2ubuntu2.dsc: done.
  Uploading nemo_4.4.2-2ubuntu2.debian.tar.xz: done.  
  Uploading nemo_4.4.2-2ubuntu2_source.buildinfo: done.  
  Uploading nemo_4.4.2-2ubuntu2_source.changes: done.
Successfully uploaded packages.


** Changed in: nemo (Ubuntu Focal)
       Status: New => In Progress

** Changed in: nemo (Ubuntu Focal)
     Assignee: (unassigned) => Brian Murray (brian-murray)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1935849

Title:
  [SRU] Reenabling toolbar in  two-pane view causes the toolbar on each
  pane to think its two separate nemo main toolbars

Status in nemo package in Ubuntu:
  Fix Released
Status in nemo source package in Focal:
  In Progress

Bug description:
  Ubuntu Cinnamon Remix 20.04.2:

  [Impact]

   * When enabling two-pane view (F3, or View -> Extra Pane), and going to 
   View and disabling then reenabling the toolbar, all the information that 
   was only on one side of the toolbar is now on both sides. This leads to 
   some weird congestion.

   * In the attached screenshots you can clearly tell something is wrong. It 
   doesn't seem intntional to include a bunch of buttons and whatever thrown 
   and cobbled together on both sides. Instead it should be kept on one.

   * The upload fixes the bug by using the same functions used to generate 
   the toolbar/panes to check for the active window pane, and that active 
   window is where the toolbar will be placed.

  [Test Plan]

   * Open Nemo

   * Enable dual-pane view. Press F3 or go to View, and select Extra
  Pane.

   * You can play around with the different directories in different tabs if    
   you so wish.

   * Go to View -> Main Toolbar. Disable it, then re-enable it.

   * Pre-upload: All the buttons are cobbled together at the top.

  [Where problems could occur]

   * Dealing with the toolbars and panes can be a little bit dangerous, and  
   be a pain (especially with memory leakage)

   * Since Nemo has lots of toolbar and panel customizations and many other 
   modes, considering the large amount of patches that continue to come out   
   for Nemo it is possible that a minor regression can open, although for 
   the most part it is unlikely since this patch has been around for over a 
   year.

  [Other Info]
   
   * This is a patch put released after the deadline for package updates   
   for focal (4.4.3) and technically this would bump the nemo version. 
   However, this is only on the 4.4x maintenance branch and not going 
   forward. This would be a focal-only patch.

   * I'll do my research for any regressions this could've possibly
  caused.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: nemo 4.4.2-2
  ProcVersionSignature: Ubuntu 5.4.0-77.86-generic 5.4.119
  Uname: Linux 5.4.0-77-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27.18
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: X-Cinnamon
  Date: Mon Jul 12 12:02:41 2021
  InstallationDate: Installed on 2021-05-17 (56 days ago)
  InstallationMedia: ubuntucinnamonremix "@BASECODENAME" (20210204)
  SourcePackage: nemo
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nemo/+bug/1935849/+subscriptions