[Bug 1930776] Re: failing test with golang 1.16

William Wilson 1930776 at bugs.launchpad.net
Wed Jun 23 17:01:00 UTC 2021


This patch resolves the broken tests by checking if the string "unclosed
action" is present in the error message rather than looking for the
whole message. This allows it to work on all versions of go.

It has been forwarded upstream: https://github.com/nicksnyder/go-
i18n/pull/260

It has been forwarded to Debian: https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=990236

** Bug watch added: Debian Bug tracker #990236
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990236

** Patch added: "lp1930776.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/golang-github-nicksnyder-go-i18n.v2/+bug/1930776/+attachment/5506503/+files/lp1930776.debdiff

** Also affects: golang-github-nicksnyder-go-i18n.v2 (Debian) via
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990236
   Importance: Unknown
       Status: Unknown

** Changed in: golang-github-nicksnyder-go-i18n.v2 (Ubuntu)
     Assignee: (unassigned) => William Wilson (jawn-smith)

** Changed in: golang-github-nicksnyder-go-i18n.v2 (Ubuntu)
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1930776

Title:
  failing test with golang 1.16

Status in golang-github-nicksnyder-go-i18n.v2 package in Ubuntu:
  Fix Committed
Status in golang-github-nicksnyder-go-i18n.v2 package in Debian:
  Unknown

Bug description:
  Running tests with golang 1.16 results in the following test failure:

  === RUN   TestExecute/hello_{{
      template_test.go:57: expected err "template: :1: unexpected unclosed action in command"; got "template: :1: unclosed action"
  --- FAIL: TestExecute (0.00s)

  
  I have reported this upstream.
  https://github.com/nicksnyder/go-i18n/issues/259

  A fix is reasonably straightforward - one could just check that error
  is non-nil for example, instead of worrying about the exact error
  text.  Or one could check that "unclosed action" is part of the error
  substring.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/golang-github-nicksnyder-go-i18n.v2/+bug/1930776/+subscriptions



More information about the Ubuntu-sponsors mailing list