[Bug 1934988] Re: Upgrade s390-tools to latest version (2.17.0)

Lukas Märdian 1934988 at bugs.launchpad.net
Tue Jul 13 13:56:01 UTC 2021


Thank you very much for providing the debdiffs!
They are looking good so far.

In the -signed package, you wouldn't even need to adopt the s390-tools-
zkey version manually as that would be generated from debian/control.in
But it's perfectly fine doing it this way as well!

For s390-tools I have a few minor remarks:
* Please add a libkmipclient1.symbols (https://wiki.debian.org/UsingSymbolsFiles) if possible.
* Please Fix the hsavmcore & lshwc typos in debian/changelog
* Please mention the new libxml2-dev build-dep in debian/changelog
* Please mention that you refreshed the patches in debian/changelog

>From what I can see you refreshed all patches, which introduced some unrelated patch header/footer changes, especially in:
0001-dumpconf-Don-t-run-the-service-in-LXC.patch
debian/patches/bashism.patch
debian/patches/install-iucvterm.patch
=> This refresh make the patches cleaner, removing the versioned directory path. So I think we can keep it as is (especially if it is mentioned in the changelog), but usually we try to avoid unrelated changes.

I saw that there is an unused patch in
debian/patches/disable.patch.DEBIAN, which seems to be a leftover from
the past, maybe we could clear/delete that one and mention it in the
changelog, too.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1934988

Title:
  Upgrade s390-tools to latest version (2.17.0)

Status in s390-tools package in Ubuntu:
  Confirmed
Status in s390-tools source package in Impish:
  Confirmed

Bug description:
  Include latest version of s390-tools 2.17.0 related to kernel 5.12+

  v2.17.0 was just released:
  https://github.com/ibm-s390-linux/s390-tools/releases/tag/v2.17.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/s390-tools/+bug/1934988/+subscriptions




More information about the Ubuntu-sponsors mailing list