[Bug 1872908] Re: bcmwl kernel module does not build with 5.6.0 kernel or later

ZdravkoG 1872908 at bugs.launchpad.net
Wed Jan 27 16:16:15 UTC 2021


Isn't more pragmatic before considering changes introduced with kernel
5.9, a backport to Focal be commited/released in advance (the kernel
there is 5.8)? 🧐😉 There is a proposal presented in Bug #1910555 comment
21! 🤔 This Bug is related to kernel 5.6. New package changes (new patch)
related to recent kernel changes might (better) be a object of new
"bug". Isn't it?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1872908

Title:
  bcmwl kernel module does not build with 5.6.0 kernel or later

Status in bcmwl package in Ubuntu:
  Fix Released
Status in bcmwl source package in Focal:
  Triaged

Bug description:
  After kernel update to 5.6.0-1007-oem wifi stopped working.
  Turned out dkms is unable to build the bcmwl module.

  The make log shows:

  ubuntu at ubuntu-inspiron-5482:~$ cat /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/make.log
  DKMS make.log for bcmwl-6.30.223.271+bdcom for kernel 5.6.0-1007-oem (x86_64)
  ons 15 apr 2020 09:19:05 CEST
  make: Entering directory '/usr/src/linux-headers-5.6.0-1007-oem'
  CFG80211 API is prefered for this kernel version
  Using CFG80211 API
    AR      /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/built-in.a
    CC [M]  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/shared/linux_osl.o
    CC [M]  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.o
    CC [M]  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_iw.o
    CC [M]  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.o
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/shared/linux_osl.c: In function ‘osl_reg_map’:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/shared/linux_osl.c:949:10: error: implicit declaration of function ‘ioremap_nocache’; did you mean ‘ioremap_cache’? [-Werror=implicit-function-declaration]
    949 |  return (ioremap_nocache((unsigned long)pa, (unsigned long)size));
        |          ^~~~~~~~~~~~~~~
        |          ioremap_cache
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/shared/linux_osl.c:949:10: warning: returning ‘int’ from a function with return type ‘void *’ makes pointer from integer without a cast [-Wint-conversion]
    949 |  return (ioremap_nocache((unsigned long)pa, (unsigned long)size));
        |         ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.c:40:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.c: In function ‘wl_set_auth_type’:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.h:52:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
     52 |  if (wl_dbg_level & WL_DBG_DBG) {   \
        |     ^
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.c:816:3: note: in expansion of macro ‘WL_DBG’
    816 |   WL_DBG(("network eap\n"));
        |   ^~~~~~
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_cfg80211_hybrid.c:817:2: note: here
    817 |  default:
        |  ^~~~~~~
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c: In function ‘wl_attach’:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:593:20: error: implicit declaration of function ‘ioremap_nocache’; did you mean ‘ioremap_cache’? [-Werror=implicit-function-declaration]
    593 |  if ((wl->regsva = ioremap_nocache(dev->base_addr, PCI_BAR0_WINSZ)) == NULL) {
        |                    ^~~~~~~~~~~~~~~
        |                    ioremap_cache
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:593:18: warning: assignment to ‘void *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
    593 |  if ((wl->regsva = ioremap_nocache(dev->base_addr, PCI_BAR0_WINSZ)) == NULL) {
        |                  ^
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c: In function ‘wl_pci_probe’:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:780:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
    780 |  if ((val & 0x0000ff00) != 0)
        |  ^~
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:782:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
    782 |   bar1_size = pci_resource_len(pdev, 2);
        |   ^~~~~~~~~
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:783:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    783 |   bar1_addr = (uchar *)ioremap_nocache(pci_resource_start(pdev, 2),
        |               ^
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c: In function ‘wl_reg_proc_entry’:
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:3376:58: error: passing argument 4 of ‘proc_create_data’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   3376 |  if ((wl->proc_entry = proc_create_data(tmp, 0644, NULL, &wl_fops, wl)) == NULL) {
        |                                                          ^~~~~~~~
        |                                                          |
        |                                                          const struct file_operations *
  In file included from /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:38:
  ./include/linux/proc_fs.h:59:31: note: expected ‘const struct proc_ops *’ but argument is of type ‘const struct file_operations *’
     59 | extern struct proc_dir_entry *proc_create_data(const char *, umode_t,
        |                               ^~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors
  make[1]: *** [scripts/Makefile.build:275: /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/shared/linux_osl.o] Error 1
  make[1]: *** Waiting for unfinished jobs....
  In file included from ./include/linux/bitmap.h:9,
                   from ./include/linux/cpumask.h:12,
                   from ./arch/x86/include/asm/cpumask.h:5,
                   from ./arch/x86/include/asm/msr.h:11,
                   from ./arch/x86/include/asm/processor.h:22,
                   from ./arch/x86/include/asm/cpufeature.h:5,
                   from ./arch/x86/include/asm/thread_info.h:53,
                   from ./include/linux/thread_info.h:38,
                   from ./arch/x86/include/asm/preempt.h:7,
                   from ./include/linux/preempt.h:78,
                   from ./include/linux/spinlock.h:51,
                   from ./include/linux/seqlock.h:36,
                   from ./include/linux/time.h:6,
                   from ./include/linux/stat.h:19,
                   from ./include/linux/module.h:13,
                   from /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/include/linuxver.h:40,
                   from /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:27:
  In function ‘strncpy’,
      inlined from ‘_wl_add_monitor_if’ at /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c:2980:2:
  ./include/linux/string.h:284:9: warning: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
    284 |  return __builtin_strncpy(p, q, size);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.c: In function ‘_wl_add_monitor_if’:
  ./include/linux/string.h:305:10: note: length computed here
    305 |   return __builtin_strlen(p);
        |          ^~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors
  make[1]: *** [scripts/Makefile.build:275: /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build/src/wl/sys/wl_linux.o] Error 1
  make: *** [Makefile:1695: /var/lib/dkms/bcmwl/6.30.223.271+bdcom/build] Error 2
  make: Leaving directory '/usr/src/linux-headers-5.6.0-1007-oem'

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: bcmwl-kernel-source 6.30.223.271+bdcom-0ubuntu5
  ProcVersionSignature: Ubuntu 5.6.0-1007.7-oem 5.6.2
  Uname: Linux 5.6.0-1007-oem x86_64
  NonfreeKernelModules: nvidia_modeset nvidia
  ApportVersion: 2.20.11-0ubuntu26
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: ubuntu:GNOME
  Date: Wed Apr 15 09:21:58 2020
  InstallationDate: Installed on 2019-12-17 (119 days ago)
  InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
  SourcePackage: bcmwl
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/bcmwl/+bug/1872908/+subscriptions



More information about the Ubuntu-sponsors mailing list