[Bug 1901344] Re: [SRU] Spotify album icon shows optimal CD disk instead of album/cover image

[Robie Basak]

Patch and quilt will cope fine with line numbers changing. But if the
context has changed and it doesn't work or applies only with fuzz, then
the patches will need reworking. Otherwise, if it works, please try to
keep the quilt patch files identical - this makes review easier.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1901344

Title:
  [SRU] Spotify album icon shows optimal CD disk instead of album/cover
  image

Status in cinnamon package in Ubuntu:
  Confirmed
Status in cinnamon-screensaver package in Ubuntu:
  Confirmed
Status in cinnamon source package in Focal:
  New
Status in cinnamon-screensaver source package in Focal:
  New
Status in cinnamon source package in Groovy:
  New
Status in cinnamon-screensaver source package in Groovy:
  New

Bug description:
  The Spotify Album Icon in the Sound Applet should show the Album/Song
  cover of the Spotify song. Instead it shows the default CD icon.

  According to upstream, the Spotify link has changed. A fix for this
  (and in the cinnamon-screensaver) is available.

  An SRU for BOTH PACKAGES, cinnamon, and cinnamon-screensaver in Focal
  and Groovy is required. (4 projects, 2 packages, 2 versions)

  SRU Template:
  [Impact]

   * When users are playing a Song via Spotify:
        * Cinnamon Package: In the sound applet, the Spotify album cover should show, but instead the plain 'CD'/Disk icon shows.
        * Cinnamon Screensaver Package: On the top left, the song information, including the album cover should show but the album cover doesn't appear.

  [Test Case]

   * Cinnamon Package: Play a song via Spotify and open the Sound applet to see the CD/Disk icon rather than the album.
   * Cinnamon Screensaver Package: Play a song via Spotify and lock the screen to see no album on the top left when you unlock when it asks for password input.

  [Regression Potential]

   * Regressions through other Spotify updates, or any link updates (the
  main cause of this bug) can cause possible regression.

   * The main cause of this bug was broken links-so another link change
  can also cause regression, so this may need to be SRU'd again sometime
  in the future.

   * Python is always known for breaking compatibility with plugins and
  such; while this is unlikely if it were to happen, it probably
  shouldn't happen before the support for Focal/Groovy expires.

  [Other Info]

   * This package requires a patch for BOTH Focal and Groovy.
   * Review the Focal patch first before we move onto the Groovy patch
   * Both will be tested.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.10
  Package: cinnamon 4.6.7-1ubuntu1
  ProcVersionSignature: Ubuntu 5.8.0-25.26-generic 5.8.14
  Uname: Linux 5.8.0-25-generic x86_64
  ApportVersion: 2.20.11-0ubuntu50
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: Unity
  Date: Sat Oct 24 15:10:36 2020
  InstallationDate: Installed on 2020-10-23 (1 days ago)
  InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022)
  ProcEnviron:
   TERM=xterm-color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: cinnamon
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1901344/+subscriptions