[Bug 1951952] Re: FTBFS - python-gear enforces TLSv1.0 usage

[Sergio Durigan Junior]

Thanks for working on this, Athos.

The debdiff looks good and I agree with the backports.  I have also
verified that the package builds fine with the proposed changes +
openssl 3.

I just have some small requests before I proceed with the upload:

1) Could you add a period at the end of each changelog entry?  I like to
treat them as sentences, and as such I consider that they should be
properly terminated.

2) Both patches should also have the "Bug-Ubuntu" DEP-3 header in order
to help determining why they're needed.

3) When I'm backporting multiple patches for a logical change like this,
I like writing a changelog entry like this:

  * Fix FTBFS with OpenSSL 3. (LP: #1951952)
    - d/p/add-SNI-support.patch: Add SNI support.
    - d/p/do-not-force-tls-v1.patch: Do not enforce TLS v1.0 usage.

I think it looks more organized and is easier to understand that the
patches are part of something bigger.


If you could address these points, I can proceed with the upload right away.

Thanks again.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1951952

Title:
  FTBFS - python-gear enforces TLSv1.0 usage

Status in python-gear package in Ubuntu:
  New

Bug description:
  python-gear forces TLSv1.0 usage, which is no longer supported by our
  libssl.

  Exception in connect loop:
  Traceback (most recent call last):
    File "/<<PKGBUILDDIR>>/gear/__init__.py", line 2500, in _doConnectLoop
      self.connectLoop()
    File "/<<PKGBUILDDIR>>/gear/__init__.py", line 2526, in connectLoop
      c = ssl.wrap_socket(c, server_side=True,
    File "/usr/lib/python3.10/ssl.py", line 1441, in wrap_socket
      return context.wrap_socket(
    File "/usr/lib/python3.10/ssl.py", line 512, in wrap_socket
      return self.sslsocket_class._create(
    File "/usr/lib/python3.10/ssl.py", line 1070, in _create
      self.do_handshake()
    File "/usr/lib/python3.10/ssl.py", line 1341, in do_handshake
      self._sslobj.do_handshake()
  ssl.SSLError: [SSL] internal error (_ssl.c:997)
  }}}

  Traceback (most recent call last):
    File "/<<PKGBUILDDIR>>/gear/tests/test_functional.py", line 73, in setUp
      self.client.waitForServer()
    File "/<<PKGBUILDDIR>>/gear/__init__.py", line 1199, in waitForServer
      self.connections_condition.wait()
    File "/usr/lib/python3.10/threading.py", line 320, in wait
      waiter.acquire()
    File "/usr/lib/python3/dist-packages/fixtures/_fixtures/timeout.py", line 52, in signal_handler
      raise TimeoutException()
  fixtures._fixtures.timeout.TimeoutException

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-gear/+bug/1951952/+subscriptions