[Bug 1773765] Re: There is a possibility that 'running' notification will remain
Corey Bryant
1773765 at bugs.launchpad.net
Wed Oct 7 19:54:50 UTC 2020
** Description changed:
- masakari-engine has two periodic tasks, one for processing 'new'
- notifications and the other for processing 'error' notifications But it
- doesn't have a periodic task for processing 'running' notifications.
+ [Impact]
+ masakari-engine has two periodic tasks, one for processing 'new' notifications and the other for processing 'error' notifications But it doesn't have a periodic task for processing 'running' notifications.
Looking at the code of masakari-engine, if the process of it goes down
immediately after it changes notification status from 'new' to
'running', then the notification which status is 'running' will remain
will not be processed by periodic tasks.
So, should masakari-engine's periodic task process the 'running' notification?
(Although it need to make such a logic that main process doesn't compete with periodic tasks.)
Or should the 'running' notification be handled by the operator?
+
+ [Test Case]
+ TBD
+
+ [Regression Potential]
+ A regression in this code could occur if either of the time intervals were calculated incorrectly which means a notification could be marked as failed perhaps long before the expiration interval. The defaults can be changed for check_expired_notifications_interval and notifications_expired_interval via masakari-engine config options which helps mitigate that risk. The defaults seem reasonable with a 10 minute periodic check and setting expired notifications to failed status only after 24 hours.
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1773765
Title:
There is a possibility that 'running' notification will remain
Status in Ubuntu Cloud Archive:
In Progress
Status in Ubuntu Cloud Archive stein series:
In Progress
Status in Ubuntu Cloud Archive train series:
In Progress
Status in Ubuntu Cloud Archive ussuri series:
In Progress
Status in Ubuntu Cloud Archive victoria series:
In Progress
Status in masakari:
Fix Released
Status in masakari stein series:
Fix Committed
Status in masakari train series:
Fix Committed
Status in masakari ussuri series:
Fix Committed
Status in masakari victoria series:
Fix Released
Status in masakari package in Ubuntu:
New
Status in masakari source package in Focal:
New
Status in masakari source package in Groovy:
New
Bug description:
[Impact]
masakari-engine has two periodic tasks, one for processing 'new' notifications and the other for processing 'error' notifications But it doesn't have a periodic task for processing 'running' notifications.
Looking at the code of masakari-engine, if the process of it goes down
immediately after it changes notification status from 'new' to
'running', then the notification which status is 'running' will remain
will not be processed by periodic tasks.
So, should masakari-engine's periodic task process the 'running' notification?
(Although it need to make such a logic that main process doesn't compete with periodic tasks.)
Or should the 'running' notification be handled by the operator?
[Test Case]
TBD
[Regression Potential]
A regression in this code could occur if either of the time intervals were calculated incorrectly which means a notification could be marked as failed perhaps long before the expiration interval. The defaults can be changed for check_expired_notifications_interval and notifications_expired_interval via masakari-engine config options which helps mitigate that risk. The defaults seem reasonable with a 10 minute periodic check and setting expired notifications to failed status only after 24 hours.
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1773765/+subscriptions
More information about the Ubuntu-sponsors
mailing list