[Bug 1887312] Re: [SRU] Cinnamon session doesn't shutdown until all apps close regardless if they act to Cinnamon's logout request

[Graham Inggs]

Joshua, there are some unnecessary changes in your debdiff (trailing
white space), e.g.

-        case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:  
+        case CSM_MANAGER_LOGOUT_SHUTDOWN_INTERACT:

-_finished_playing_logout_sound (ca_context *c, uint32_t id, int error, void *userdata) 
+_finished_playing_logout_sound (ca_context *c, uint32_t id, int error, void *userdata)

Would you please trim it down to only what's needed?

Also, this:

Bug: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug-<Vendor>: https://github.com/linuxmint/cinnamon/issues/3752

should be:

Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312
Bug: https://github.com/linuxmint/cinnamon/issues/3752

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1887312

Title:
  [SRU] Cinnamon session doesn't shutdown until all apps close
  regardless if they act to Cinnamon's logout request

Status in cinnamon-session package in Ubuntu:
  Fix Released
Status in cinnamon-session source package in Focal:
  New

Bug description:
  Reference to upstream commit:  csm-manager.c: Don't let programs that
  exit without responding to cinnamon-session's request delay the
  shutdown.

  This fixes the following issue:
  https://github.com/linuxmint/cinnamon/issues/3752

  SRU TEMPLATE:

  [Impact]

   * When Cinnamon is exiting, it will wait for apps to close before it shutsdown.
  * Using normal shutdown procedures it can be overwritten (e.g. shutdown -a)  and will save time.
  * The commit upstream removes delay in Cinnamon Session shutdown.

  [Test Case]

   * Open an app that requires time to shutdown-e.g. Steam.
   * Shut down and look for the time that it takes to shutdown.
   * Force shutdown Cinnamon from terminal
   * Notice it takes no time to shutdown.

  [Regression Potential]

   * Regression is nearly impossible due to this coming from upstream,
  and the new versions in Groovy. Development will probably still
  continue through patches.

   * This is also something GNOME from upstream patched.

   * Regression could be possible if things such as memory/RAM speed
  change or an update of Cinnamon (such as muffin Window Manager) occur
  overtime.

   * As new apps come by and it takes time to actually safely close the
  applications, this can cause possible lag and unsafe possible
  corruption but this is very unlikely.

  [Other Info]

   * The bug patch is from upstream (see the commit that closed the issue above)
   * This is part of the bug fixes in cinnamon-session upstream.

  An SRU is strongly recommended. Above is the template. Debdiff will be
  applied in comments.

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: cinnamon-session (not installed)
  ProcVersionSignature: Ubuntu 5.4.0-40.44-generic 5.4.44
  Uname: Linux 5.4.0-40-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27.3
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: ubuntu:GNOME
  Date: Sun Jul 12 15:46:08 2020
  InstallationDate: Installed on 2020-04-23 (80 days ago)
  InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
  ProcEnviron:
   TERM=xterm-256color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: cinnamon-session
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cinnamon-session/+bug/1887312/+subscriptions