[Bug 1905630] Re: [SRU] Cinnamon and applications won't run a sh script if the directory has spaces in its name

[Joshua Peisach]

** Patch removed: "cinnamon-desktop_4.4.1-3ubuntu0.1.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/cinnamon-desktop/+bug/1905630/+attachment/5438085/+files/cinnamon-desktop_4.4.1-3ubuntu0.1.debdiff

** Patch added: "Fixed patch (2nd revision, screwed up debdiff command)"
   https://bugs.launchpad.net/ubuntu/+source/cinnamon-desktop/+bug/1905630/+attachment/5438086/+files/cinnamon-desktop_4.4.1-3ubuntu0.1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1905630

Title:
  [SRU] Cinnamon and applications won't run a sh script if the directory
  has spaces in its name

Status in cinnamon-desktop package in Ubuntu:
  Confirmed

Bug description:
  [Impact]

   * When running a shell script in a directory named with a space
  ('test name' compared to 'test-name'), the default selected terminal
  will not run.

   * A typical issue found when trying to run it in a directory with the
  name of a space is saying "no such file or directory" (yes this also
  includes if the shell script name has spaces in it too) See
  https://github.com/linuxmint/nemo/issues/2499

   * It should basically work anyways.

   * It runs (default terminal) -x, but it should run -- instead. GNOME
  Terminal is mostly used for Cinnamon. Also in gnome-terminal using -x
  is deprecated.

  [Test Case]

   * Create a new directory, or go inside a directory. If creating, make
  the directory have a space in there (e.g. 'sru test')

   * Create a shell script, say "echo apple &" or something

   * if you didn't make the directory have a space in it's name have the
  shell script have a space in its name

   * Make the script an executable and execute

   * Terminal should fail (use gnome-terminal i suggest)

  [Where problems could occur/Regression Potential]

   * While there isn't too much of a risk, there is quite some factors.

   * With terminals updating, there can be options that don't support
  the option of '--'.

   * Not just that with the terminal updates but also some terminals
  might not even work with it in the first place

   * The risk involved is that it may or may not work-but it truly
  depends on user preference.

   * Keep in mind this is a LIBRARY so if you want to force specific
  terminals that would require a patch in another C code or debian
  packaging.

  [Other Info]

   * Groovy needs a patch for this too! I'm starting with Focal just to get a review and then when the fix is released and out of -proposed we can test groovy.
   * None but per usual I hope to use this as it count to help with my UbuntuContributingDeveloper/PPU application at https://wiki.ubuntu.com/itzswirlz/Applications/UbuntuContributingDeveloper (Goal: ~15 SRU's)

  ProblemType: Bug
  DistroRelease: Ubuntu 20.10
  Package: cinnamon-desktop-data 4.6.4-1
  ProcVersionSignature: Ubuntu 5.8.0-29.31-generic 5.8.14
  Uname: Linux 5.8.0-29-generic x86_64
  ApportVersion: 2.20.11-0ubuntu50.1
  Architecture: amd64
  CasperMD5CheckResult: skip
  CurrentDesktop: ubuntu:GNOME
  Date: Wed Nov 25 18:05:31 2020
  InstallationDate: Installed on 2020-10-23 (33 days ago)
  InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Release amd64 (20201022)
  PackageArchitecture: all
  ProcEnviron:
   TERM=xterm-256color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: cinnamon-desktop
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cinnamon-desktop/+bug/1905630/+subscriptions