[Bug 1882375] Re: [SRU Patch Available] Cinnamon custom keyboard shortcuts don't work until logout

[Joshua Peisach]

** Description changed:

  [Impact]
  
-  * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
-  reset of Cinnamon occurs.
-  * This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).
+  * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
+  reset of Cinnamon occurs.
+  * This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).
  
  [Test Case]
  
-  * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
-  not work until you log out and log in again.
+  * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
+  not work until you log out and log in again.
  
  [Regression Potential]
  
-  * Through this change it looks like there won't be any regression. Later on I will backport more
-  patches added to cinnamon.
  
-  * Two commits were made on this-another one was a revisit that fixed
+  * This patch ensures that a GSettings change is fired every time-and to avoid regression, also make sure that there is an actual keyboard shortcut, a dummy shortcut is added to avoid further possible regression.
+ 
+  * Regression could be possible through primarily Python updates. I will
+ keep noting if anything happens but so far, nothing has really broken.
+ 
+  * Through this change it looks like there won't be any regression. Later on I will backport more
+  patches added to cinnamon.
+ 
+  * Two commits were made on this-another one was a revisit that fixed
  one so it looks like we are stable enough to not have to worry about
  regressions.
  
-  * The updated version of this patch actually fixes a regression-we
+  * The updated version of this patch actually fixes a regression-we
  should be okay.
  
  [Other Info]
  
-  * Backporting patch from Linux Mint upstream, solved a few other issues
-  * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
-  * This is my 3rd attempt, fixed changelog and version
+  * Backporting patch from Linux Mint upstream, solved a few other issues
+  * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
+  * This is my 3rd attempt, fixed changelog and version
  
  [Original Description]
  
  Description:	Ubuntu 20.04 LTS
  Release:	20.04
  cinnamon: 4.4.8-4
  cinnamon-settings-daemon: 4.4.0-3
  
  Steps to Reproduce:
  - on Cinnamon desktop, run cinnamon-settings
  - go to Keyboard > Shortcuts > Custom Shortcuts
  - add a custom shortcut, or edit the command or shortcut of an existing custom shortcut
  
  Expected behavior:
  the shortcut should become active immediately
  
  Actual behavior:
  the shortcut does not work until you log out and log in again
  
  This seems similar to bug #1243532, but I'm reporting this as a new bug
  now because it is cinnamon-specific. Other shortcuts (e.g. Close Window)
  are updated immediately, this only affects custom shortcuts. I think
  this bug appeared in 20.04.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1882375

Title:
  [SRU Patch Available] Cinnamon custom keyboard shortcuts don't work
  until logout

Status in cinnamon package in Ubuntu:
  Fix Released
Status in cinnamon source package in Focal:
  In Progress
Status in cinnamon source package in Groovy:
  Fix Released

Bug description:
  [Impact]

   * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
   reset of Cinnamon occurs.
   * This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).

  [Test Case]

   * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
   not work until you log out and log in again.

  [Regression Potential]

  
   * This patch ensures that a GSettings change is fired every time-and to avoid regression, also make sure that there is an actual keyboard shortcut, a dummy shortcut is added to avoid further possible regression.

   * Regression could be possible through primarily Python updates. I
  will keep noting if anything happens but so far, nothing has really
  broken.

   * Through this change it looks like there won't be any regression. Later on I will backport more
   patches added to cinnamon.

   * Two commits were made on this-another one was a revisit that fixed
  one so it looks like we are stable enough to not have to worry about
  regressions.

   * The updated version of this patch actually fixes a regression-we
  should be okay.

  [Other Info]

   * Backporting patch from Linux Mint upstream, solved a few other issues
   * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
   * This is my 3rd attempt, fixed changelog and version

  [Original Description]

  Description:	Ubuntu 20.04 LTS
  Release:	20.04
  cinnamon: 4.4.8-4
  cinnamon-settings-daemon: 4.4.0-3

  Steps to Reproduce:
  - on Cinnamon desktop, run cinnamon-settings
  - go to Keyboard > Shortcuts > Custom Shortcuts
  - add a custom shortcut, or edit the command or shortcut of an existing custom shortcut

  Expected behavior:
  the shortcut should become active immediately

  Actual behavior:
  the shortcut does not work until you log out and log in again

  This seems similar to bug #1243532, but I'm reporting this as a new
  bug now because it is cinnamon-specific. Other shortcuts (e.g. Close
  Window) are updated immediately, this only affects custom shortcuts. I
  think this bug appeared in 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cinnamon/+bug/1882375/+subscriptions