[Bug 1877758] Re: [SRU] Update to 1.5.2-1

[Mathew Hodson]

** Changed in: tilda (Ubuntu Focal)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1877758

Title:
  [SRU] Update to 1.5.2-1

Status in tilda:
  New
Status in tilda package in Ubuntu:
  Fix Released
Status in tilda source package in Focal:
  New

Bug description:
  [Impact]

  This is a bug fix release that includes:
  - Translation updates
  - A fix for matching of URLs. Without this fix the URL matching feature is broken and cannot be used.
  - A fix for an issue that can cause the close-tab confirmation dialog to reappear when the dialog is canceled.
  - A fix for an issue that could cause the tilda window to appear behind panels in fullscreen mode.
  - A fix for a leak in the signal handling code that caused the "switch-tab" signal handler to be re-added every time a tab was opened.
  - An update to the URL matching regex that adds the '@' character. Without this fix URLs that contain an '@' character are not correctly matched in tilda and are cut-off before the '@' character.

  NEWS / Changelog
  - https://github.com/lanoxx/tilda/commit/370a5da668f94a4dcd130936ad5dbc3a9285bad9

  All changes are documented in the upstream milestones:
  - 1.5.2 https://github.com/lanoxx/tilda/milestone/8?closed=1
  - 1.5.1 https://github.com/lanoxx/tilda/milestone/7?closed=1

  [Test Case]

  - URL matching:
  1. Print a URL in the terminal, such as with `echo https://google.com`
  2. Hover over the URL with the mouse. Without this patch the URL will not be turned into a link and cannot be clicked.

  - Context Menu Reappearing:
  1. Open context menu
  2. Close context menu
  3. Open a new tab
  4. Close the new tab -> Confirmation dialog should open (if not this can be configured in the settings).
  5. Click cancel -> Without this fix confirmation dialog will re-appear.

  - Fullscreen tilda window appears behind panel:
  1. Open tilda window
  2. Switch to fullscreen (via F11 by default)
  3. Toggle tilda window to hidden and show again.
  4. Observe that without this fix, the tilda window can sometimes re-appear behind panels.

  - Signal handling leak:
  1. There is no test case for this issue. Without the fix signal handles are continued to be registered when a new tab is opened and are not correctly cleaned up when a tab is closed causing a linear increase in callbacks when a user switches tabs.

  - Handle '@' character
  1. Output a URL which contains an '@' character, without this patch the URL will be cut-off before the '@' character, but we cannot observe this because URL matching is broken in 1.5.0. With this fix we can observe that the URL is correctly matched.

  [Regression Potential]

  Regression potential overall is very low. All changes fix known bugs
  and no new features are added.

  The regression potential for URL matching is minimal. Without this
  change the URL matching feature is broken. Even if this added a
  regression to the URL matching code this is still better than having
  no URL matching at all. The change for the '@' character matching
  could in the worse case affect matching of other URLs that.

  The regression potential for the context menu change is minimal, we
  only add a new signal handler to ensure that the menu is correctly
  detached from the window when the context menu is closed.

  The regression potential for the switch-tab signal handler change is
  minimal, the code itself has not changed, the signal is just
  registered to a different object to avoid registering it multiple
  times.

  
  [Other Info]

  This is my first SRU bug, please let me know if anything is missing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/tilda/+bug/1877758/+subscriptions