[Bug 1883027] Re: dump_acpi_tables.py: fix incorrect output and change format

[Mathew Hodson]

** Changed in: apport (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: apport (Ubuntu Groovy)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1883027

Title:
  dump_acpi_tables.py: fix incorrect output and change format

Status in Apport:
  Confirmed
Status in apport package in Ubuntu:
  Confirmed
Status in apport source package in Focal:
  Confirmed
Status in apport source package in Groovy:
  Confirmed

Bug description:
  dump_acpi_tables.py generates log files that is similar as the output
  from "acpidump" in acpica-tools. The output can be passed to other
  utilities in acpica-tools and fwts.

  It, however, has some subtle differences and some errors.

  Summary:

  1. ACPI tables have 4-char signatures - meaning SSDT's are SSDT, not
  SSDT1, SSDT2 and so on. Each table is unique by its table ID.

  Original:
    SSDT1, SSDT2, SSDT3 ...

  Changed:
    SSDT, SSDT, SSDT ...

  2. (Minor) acpidump outputs are all in upper cases

  3. (Minor) acpidump offset are aligned by data, not address

  Original:
    FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D  SAVCRDCANCRNrNPM
    10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43  V............RDC

  Changed:
      FFF0: 53 41 56 43 52 44 43 41 4E 43 52 4E 72 4E 50 4D  SAVCRDCANCRNrNPM
     10000: 56 0A 04 00 0C FC FF FF FF 0A 03 0A 03 52 44 43  V............RDC

  4. (Bug) dump_acpi_tables.py generates an extra line when data sizes
  are multiple of 16 bytes

  Original:
      05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44  00.....HPSD.SPSD
      05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44                                                  00.....HPSD.SPSD

  Corrected:
      05F0: 30 30 0B 00 08 00 A4 48 50 53 44 A4 53 50 53 44  00.....HPSD.SPSD

  5. (Bug) dump_acpi_tables.py misses an line when data sizes are
  multiple of 15 bytes

  Original:
      07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43  B..\/._SB_UBTCCC

  Corrected:
      07E0: 42 0A 87 5C 2F 03 5F 53 42 5F 55 42 54 43 43 43  B..\/._SB_UBTCCC
      07F0: 49 33 86 5C 2E 5F 53 42 5F 55 42 54 43 0A 80     I3.\._SB_UBTC..

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1883027/+subscriptions