[Bug 1311056] [NEW] [SRU] apt-add-repository adds duplicate commented/disabled source lines

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Dave Jones (waveform):

Impact
======

Under most circumstances, the impact is minimal (a few extra redundant
comment lines in apt sources. However, if users are automating source
removal / addition on a machine (as in comment 11), there is the
potential to wind up with an excessively large (and thus slow to parse)
apt sources configuration.

Test packages for the supported releases are available from the
following PPA:

https://launchpad.net/~waveform/+archive/ubuntu/python-apt

Built from the source which can be found in the following branches:

https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
/python-apt/+ref/sru-dupe-ppa-xenial

https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
/python-apt/+ref/sru-dupe-ppa-bionic

https://code.launchpad.net/~waveform/ubuntu/+source/python-apt/+git
/python-apt/+ref/sru-dupe-ppa-eoan

Test Case
=========

* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/sources.list.d/deadsnakes*.list
* Note the presence of one uncommented "deb" line, and one commented "deb-src" line
* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/sources.list.d/deadsnakes*.list
* Note the uncommented "deb" line is still there but the commented "deb-src" line has now been duplicated
* sudo add-apt-repository ppa:waveform/python-apt
* sudo apt upgrade  # update python-apt to fixed version
* sudo add-apt-repository -y ppa:deadsnakes/ppa
* cat /etc/apt/sources.list.d/deadsnakes*.list
* Note there has been no further duplication of the commented "deb-src" line

Regression Potential
====================

Minimal; test cases have been added to cover the duplication case, and
to cover the enabling of sources (which was not covered by existing
tests, but was part of the code altered to fix the duplication case),
and insertion of sources at a position (again, not covered by existing
tests but modified as part of the fix). The test case has been used
successfully on all targeted releases (xenial, bionic, and eoan).

Original Description
====================

Trusty Tahr 14.04

0 root at osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list
deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
0 root at osprey:/etc/apt/sources.list.d#apt-add-repository -y ppa:aims/aims-desktop
gpg: keyring `/tmp/tmp0ufdhnmv/secring.gpg' created
gpg: keyring `/tmp/tmp0ufdhnmv/pubring.gpg' created
gpg: requesting key BE796FF2 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp0ufdhnmv/trustdb.gpg: trustdb created
gpg: key BE796FF2: public key "Launchpad PPA for AIMS" imported
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)
OK
0 root at osprey:/etc/apt/sources.list.d#cat aims-aims-desktop-trusty.list deb http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
# deb-src http://ppa.launchpad.net/aims/aims-desktop/ubuntu trusty main
0 root at osprey:/etc/apt/sources.list.d#

That deb-src line should have stayed commented out, and not been
duplicated. (Commented deb lines should of course be uncommented, as
already fixed per https://bugs.launchpad.net/ubuntu/+source/python-
apt/+bug/1042916 .)

** Affects: python-apt (Ubuntu)
     Importance: High
         Status: Fix Released

** Affects: python-apt (Ubuntu Xenial)
     Importance: Undecided
         Status: New

** Affects: python-apt (Ubuntu Bionic)
     Importance: Undecided
         Status: New

** Affects: python-apt (Ubuntu Eoan)
     Importance: Undecided
         Status: New


** Tags: bot-comment canonical-bootstack id-5d65087107d6ae450d988462 patch
-- 
[SRU] apt-add-repository adds duplicate commented/disabled source lines
https://bugs.launchpad.net/bugs/1311056
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.