[Bug 1886300] Re: rename.ul refuses to rename links that don't resolve (regression)

[Brian Murray]

Hello gregrwm, or anyone else affected,

Accepted util-linux into focal-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/util-
linux/2.34-0.1ubuntu9.1 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
focal to verification-done-focal. If it does not fix the bug for you,
please add a comment stating that, and change the tag to verification-
failed-focal. In either case, without details of your testing we will
not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Bug watch added: Debian Bug tracker #966106
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966106

** Also affects: util-linux (Debian) via
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=966106
   Importance: Unknown
       Status: Unknown

** Changed in: util-linux (Ubuntu Focal)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1886300

Title:
  rename.ul refuses to rename links that don't resolve (regression)

Status in util-linux package in Ubuntu:
  Fix Committed
Status in util-linux source package in Focal:
  Fix Committed
Status in util-linux source package in Groovy:
  Fix Committed
Status in util-linux package in Debian:
  Unknown

Bug description:
  [Impact]

  rename.ul refuses to rename links that don't resolve.

  bionic rename.ul renames links whether or not they resolve (util-linux
  2.31.1-0.4ubuntu3.6).

  focal rename.ul refuses to rename links that don't resolve
  (regression) (util-linux 2.34-0.1ubuntu9).

  Eoan is EOL, so removed.

  
  [Test case]

  Commit has good test case. I paste it here

  Before:

    $ touch file-found
    $ ln -s file-found symlink-1
    $ ./rename sym symbolic- symlink-1	# XPASS.
    $ echo $?
    0

    $ ln -s file-not-found symlink-2
    $ ./rename sym symbolic- symlink-2	# FAIL! REGRESSION.
    rename: symlink-2: not accessible: No such file or directory
    $ echo $?
    1

    $ ./rename sym symbolic- symlink-3	# XFAIL.
    rename: symlink-3: not accessible: No such file or directory
    $ echo $?
    1

    $ touch file-found
    $ ./rename found existing file-found	# XPASS.
    $ echo $?
    0

    $ ./rename found existing file-not-found # XFAIL.
    rename: file-not-found: not accessible: No such file or directory
    $ echo $?
    1

  After:

    $ touch file-found
    $ ln -s file-found symlink-1
    $ ./rename sym symbolic- symlink-1	# XPASS.
    $ echo $?
    0

    $ ln -s file-not-found symlink-2
    $ ./rename sym symbolic- symlink-2	# PASS! REGRESSION FIXED.
    $ echo $?
    0

    $ ./rename sym symbolic- symlink-3	# XFAIL.
    rename: symlink-3: not accessible: No such file or directory
    $ echo $?
    1

    $ touch file-found
    $ ./rename found existing file-found	# XPASS.
    $ echo $?
    0

    $ ./rename found existing file-not-found # XFAIL.
    rename: file-not-found: not accessible: No such file or directory
    $ echo $?
    1

  
  [Regression Potential]
  This commit changes code that checking accessibility to file or sym link. 
  If this fails, rename command will not work properly.it could be crashed or causes failure of rename. 

  
  [Original Description]

  rename.ul refuses to rename links that don't resolve.

  bionic rename.ul renames links whether or not they resolve (util-linux
  2.31.1-0.4ubuntu3.6).

  focal rename.ul refuses to rename links that don't resolve
  (regression) (util-linux 2.34-0.1ubuntu9).

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: util-linux 2.34-0.1ubuntu9
  ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
  Uname: Linux 5.4.0-21-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27.3
  Architecture: amd64
  CasperMD5CheckResult: skip
  Date: Sat Jul  4 20:38:06 2020
  InstallationDate: Installed on 2020-04-05 (90 days ago)
  InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Beta amd64 (20200331)
  ProcEnviron:
   LC_TIME=en_DK.utf8
   TERM=screen
   PATH=(custom, no user)
   LANG=en_US.utf8
   SHELL=/bin/bash
  SourcePackage: util-linux
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1886300/+subscriptions