[Bug 1881976] Re: apport-gtk and apport-kde install xiterm+thai as dependency (x-terminal-emulator)

[Eric Desrochers]

[sts-sponsor note]

Package doesn't build due to new pycodestyle (2.6.0-1~20.04.1) found in
focal-proposed as opposed to its former version (2.5.0-2) that now
detects the following during the test:

Running pycodestyle...
./setup.py:78:33: E741 ambiguous variable name 'l'
./test/test_fileutils.py:380:13: E741 ambiguous variable name 'l'
./test/test_signal_crashes.py:141:13: E741 ambiguous variable name 'l'
./test/test_ui.py:1773:43: E741 ambiguous variable name 'l'
./backends/packaging-apt-dpkg.py:1222:13: E741 ambiguous variable name 'l'
./backends/packaging-apt-dpkg.py:1233:17: E741 ambiguous variable name 'l'
./build/lib/apport/__init__.py:67:13: E741 ambiguous variable name 'l'
./build/lib/apport/fileutils.py:332:9: E741 ambiguous variable name 'l'
./build/lib/apport/hookutils.py:620:9: E741 ambiguous variable name 'l'
./build/lib/apport/hookutils.py:630:9: E741 ambiguous variable name 'l'

This has been addressed in apport groovy where ambiguous 'l' have been
replaced by 'line'.

# d/changelog
apport (2.20.11-0ubuntu42) groovy; urgency=medium

  * Fix pep8 errors regarding ambiguous variables.

 -- Brian Murray <brian at ubuntu.com>  Wed, 24 Jun 2020 09:15:51 -0700


Patch example:
...
-                            for l in lines:
-                                fd.write(l)
+                            for line in lines:
+                                fd.write(line)
...

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1881976

Title:
  apport-gtk and apport-kde install xiterm+thai as dependency (x
  -terminal-emulator)

Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Focal:
  Fix Committed

Bug description:
  [Impact]

   * When installing apport-gtk (or apport-kde) on a non-GUI installation (cloud image, server image) as a dependency providing x-terminal-emulator xiterm+thai package is pulled in, which is not appropriate for most locales.
  My understanding is it was selected due to lowest number of unsatisfied dependencies.

  [Test Case]

   * lxc launch ubuntu:20.04 test
   * lxc shell test
   * apt update
   * apt install apport-gtk
   * Examine the packages listed to be installed: xiterm+thai is one of them.

  [Regression Potential]

   * In dedicated archive mirrors with limited number of packages
  changing that may cause errors due to packages missing in the archive.
  However, that's unlikely.

  [Other Info]

   * It is not affecting bionic, since x-terminal-emulator is listed as 'Suggests' not 'Depends' there.
   * Original bug description:

  Vanilla install of Ubuntu 20.04 set to an Australian locale includes the "Thai X Terminal" package.
  This package should not be included.

  I noticed that it is also reported against Xubuntu and Lubuntu:
  https://bugs.launchpad.net/lubuntu-next/+bug/1747341

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apport/+bug/1881976/+subscriptions