[Bug 1845005] Re: rmap stressor should return EXIT_NO_RESOURCE when out of free space

[Timo Aaltonen]

Hello Colin, or anyone else affected,

Accepted stress-ng into bionic-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/stress-
ng/0.09.25-1ubuntu4 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: stress-ng (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags removed: verification-done
** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1845005

Title:
  rmap stressor should return EXIT_NO_RESOURCE when out of free space

Status in stress-ng package in Ubuntu:
  Fix Released
Status in stress-ng source package in Bionic:
  Fix Committed
Status in stress-ng source package in Disco:
  Fix Released
Status in stress-ng source package in Eoan:
  Fix Released

Bug description:
  == SRU Justification BIONIC, DISCO ==

  When running the rmap stressor on systems with small file systems the
  fallocate can fail to allocate a large file when running with may
  stressors causing the stress test to exit with EXIT_FAILURE.  The
  correct return is actually EXIT_NO_RESOURCE as there are not enough
  resources to run the stress-test.

  == Test Proceedure ==

  Run rmap on a small file system with many stressors invoked, e.g.

  stress-ng --rmap 2048 -t 60

  without the fix, the test will exit with a failure. With the fix the
  stressor will terminate early with just an out of resource message
  rather than a hard test failure.

  == Fix ==

  upstream commit:

  commit 38fd9c6ff96cb7e73f7cb3758bb303d874ad11b5
  Author: Colin Ian King <colin.king at canonical.com>
  Date:   Mon Sep 23 14:11:26 2019 +0100

      stress-rmap: don't make fallocate failures a rmap test failure (LP: #1845005)
      
      The rmap stressor should return EXIT_NO_RESOURCE and not EXIT_FAILURE
      when attempting to fallocate a file to rmap onto. This makes it a
      non-critical failure based on lack of resources rather than a stress
      test failure because rmap didn't fail per-se.
      
      Signed-off-by: Colin Ian King <colin.king at canonical.com>

  == Regression Potential ==

  This is a minor change to a return status and closing of opened
  resources. The behaviour is now different on an allocation failure
  error type, so applications running this stress test that checking a
  specific error return may need updating. This is unlikely as most code
  checks for 0 success and non-zero for failure.

  ---------------------------------------------

  
  The rmap stressor should return EXIT_NO_RESOURCE and not EXIT_FAILURE when attempting to fallocate a file to rmap onto. This makes it a non-critical failure based on lack of resources rather than a stress test failure because rmap failed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/stress-ng/+bug/1845005/+subscriptions