[Bug 1820768] Re: [SRU] support new cab and new docking firmware upgrade in fwupd 1.2.10

[Steve Langasek]

I have added an explicit test case for the packaging changes, since that
is a large part of why this SRU has taken as long to sort out - we need
to ensure that the package upgrades work correctly.

This test case uses update-manager, and NOT apt-get, because the
behavior is different between the two regarding the removal of packages.
I think the current upload will actually FAIL verification, because
there is a Breaks: from the new fwupdate to fwupdate-signed, and
fwupdate-signed is also installed by default.  I expect update-manager
to refuse to upgrade fwupdate in order to avoid removing fwupdate-
signed.

There is also a bug in the packaging, which is that fwupdate has an
unversioned Breaks: against fwupdate-signed; if this is required, it
should be an unversioned Conflicts: instead.  However, per the previous
comment, I think we probably need to do something else here (such as
making fwupdate-signed also be a dummy package built from fwupdate
source which depends on fwupd-signed, or dropping the Breaks: entirely
and ignoring the fact that fwupdate-signed is kept on disk, if that is
appropriate).

Finally, I see that fwupd is introducing a Recommends: on bolt,
tpm2-tools, and tpm2-abrmd in addition to fwupd-signed.  This is not
allowed; tpm2-abrmd and tpm2-tools are in universe in bionic.  Also,
while bolt is in main, in bionic it is only in the ubuntu-desktop task
(via a Recommends: from gnome-shell), whereas fwupdate is a recommends
of all of the desktop metapackages.  We cannot promote bolt to be pulled
into all of the desktop flavor images in SRU without discussion with the
flavor teams.

I will reupload fwupd to drop these added Recommends.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1820768

Title:
  [SRU] support new cab and new docking firmware upgrade in fwupd 1.2.10

Status in OEM Priority Project:
  Triaged
Status in fwupd package in Ubuntu:
  Fix Released
Status in fwupd-signed package in Ubuntu:
  Fix Released
Status in fwupdate package in Ubuntu:
  Fix Released
Status in libxmlb package in Ubuntu:
  Fix Released
Status in fwupd source package in Bionic:
  Triaged
Status in fwupd-signed source package in Bionic:
  Fix Committed
Status in fwupdate source package in Bionic:
  New
Status in libxmlb source package in Bionic:
  Fix Committed

Bug description:
  * Impact

  Bios vendor is pushing to put the new design into cab file, and also
  new docking DW19 needs the new fwupd to support it.

  That needs new fwupd to support.

  * Background:
   1. most user does firmware update via gnome-software and it talk to fwupd.
   2. only very very limited user will call /usr/bin/fwupdate from the command line.
   3. the new fwupd will need a new fwupd-signed. So we will remove fwupdate-signed.

  * Current test result before we have something in proposed channel:
   1. new fwupd works well with gnome-software, so we should be safe to go.
   2. for those very limited user, they can call /usr/lib/fwupd/fwupdate to replace /usr/bin/fwupdate. so it should be safe to remove fwupdate.

  * Test case

  A.
  1. install the new fwupd, and plugin the new docking - DW19.
  2. fwupdmgr get-devices and check if all internal device can properly show

  B.
  1. If you can get new cab file, try to use fwupdmgr install XX.cab to see if can work properly.

  C.
  1. If you can get a machine that have some firmware update pending, try to go gnome-software, and click refresh with the new fwupd, you should be able to see the pending firmware showed there. Which proves that it can properly be integrated with gnome. (ycheng-twn have a laptop with that condition, and he can verify that one

  D.
  1. Install an 18.04 Ubuntu Desktop system.
  2. Enable bionic-proposed.
  3. Run update-manager.
  4. Ensure that the fwupd and fwupd-signed packages are installed without error.

  * Regression potential

  Since the upstream maintainer is back up this upgrade, and he also
  works in a major computer vendor and works closely with the BIOS team,
  it should be fairly low risk.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1820768/+subscriptions