[Bug 1838358] Re: Ibus causes gnome-shell to freeze when password fields are selected in Firefox
Łukasz Zemczak
1838358 at bugs.launchpad.net
Thu Aug 8 08:05:12 UTC 2019
Hello Matthew, or anyone else affected,
Accepted ibus into bionic-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/ibus/1.5.17-3ubuntu5
in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed. Your feedback will aid us getting this
update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.
Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
advance for helping!
N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.
** Changed in: ibus (Ubuntu Bionic)
Status: In Progress => Fix Committed
** Tags added: verification-needed verification-needed-bionic
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1838358
Title:
Ibus causes gnome-shell to freeze when password fields are selected in
Firefox
Status in ibus package in Ubuntu:
Fix Released
Status in ibus source package in Bionic:
Fix Committed
Bug description:
[Impact]
The following has been seen in a VMware Horizon VDI. I cannot reproduce this
issue myself.
When a user interacts with any password field in Firefox, gnome-shell
and Firefox both freeze and the system becomes unusable. If you ssh
into the system and terminate Firefox, gnome-shell unfreezes.
This only happens when the environment variable GTK_IM_MODULE is set to "ibus". If you unset the variable, or change it to
GTK_IM_MODULE=gtk-im-context-simple and then start Firefox, everything works as intended.
This has been seen before with gnome-shell 3.28.4-0ubuntu18.04.1, ibus
1.5.17-3ubuntu4 and Firefox versions starting with 68.0+build3-0ubuntu0.18.04.1
Note: Chrome[ium] and other applications do not trigger it, and it cannot be
reproduced in other desktop environments.
This seems to be an interaction issue between ibus and gnome-shell.
[Test Case]
Launch firefox from within a gnome-session, making sure the
GTK_IM_MODULE is set to "ibus". Note, this is the default value.
$ env GTK_IM_MODULE="ibus" firefox
Navigate to any website which has a password field. Wikipedia or
Reddit will do.
Click a password field and attempt to enter text. Firefox and gnome-
shell both lock up and stay frozen for an extended period of time.
Now, try it with the fix by enabling:
$ env IBUS_DISCARD_PASSWORD=1 firefox
When you enter text into a password field, ibus should directly pass through
the text and the problem will be solved.
We can also ask it to always apply for a specific application with:
$ export IBUS_DISCARD_PASSWORD_APPS="firefox"
$ firefox
Again, when you enter text into a password input field, the problem will be
solved.
Test package is available here:
https://launchpad.net/~mruffell/+archive/ubuntu/sf235370-test
Please test with the revised version,
1.5.17-3ubuntu4+sf235370v20190731b1.
[Regression Potential]
This change has a low risk of regression, because the default behaviour is
unchanged. To be able to use the password input field discard functionality, a user has to explicitly set an environment variable for the specific process, or set a regex that matches a process name.
This means the fix is not enabled by default on any machines, and will
only be utilised by those suffering problems and go and manually set
environment variables or have their system administrator enable the
environment variables permanently.
This commit is present in upstream ibus from version ibus-1.5.19
onward, and is currently present in cosmic, disco and eoan.
If a regression occurs, users can ensure that the environment
variables are unset and continue working.
[Other info]
* This patch is functionally the same as ibus-xx-f19-password.patch,
but just hides the features behind environment variables.
* When ibus is built with the patch ibus-xx-f19-password.patch which
was dropped in ibus-1.5.17-2, the problem is solved.
Instead of using ibus-xx-f19-password.patch, we will instead fix it with
upstream commit f328fd67f479faa46ca87bf3c85eed7080ec5ec0:
https://github.com/ibus/ibus/commit/f328fd67f479faa46ca87bf3c85eed7080ec5ec0
Subject: client/gtk2: Add IBUS_DISCARD_PASSWORD for firefox and chrome
Author: fujiwarat <takao.fujiwara1 at gmail.com>
This implements the password discard functionality found in
ibus-xx-f19-password.patch and places it behind two environment variables,
IBUS_DISCARD_PASSWORD and IBUS_DISCARD_PASSWORD_APPS.
IBUS_DISCARD_PASSWORD is for a single process, and IBUS_DISCARD_PASSWORD_APPS
lets you set a regex of process names to filter and enable the fix for.
If IBUS_DISCARD_PASSWORD is set or IBUS_DISCARD_PASSWORD_APPS is set
with the process name which input is being placed into password
fields, ibus will pass through the input to the application without
any processing.
* This only affect Bionic
- Upstream first introduction:
$ git describe --contains f328fd67f479faa46ca87bf3c85eed7080ec5ec0
1.5.19~7
- Ubuntu ibus current version found in the archive:
$ rmadison ibus
==> ibus | 1.5.17-3ubuntu4 | bionic
ibus | 1.5.19-1ubuntu1 | cosmic
ibus | 1.5.19-1ubuntu2 | disco
ibus | 1.5.19-4ubuntu2 | eoan
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1838358/+subscriptions
More information about the Ubuntu-sponsors
mailing list