[Bug 1825250] [NEW] ethmonitor does not list interfaces without assigned IP address

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[Impact]
Some network interfaces will not be monitored by ethmonitor

[Description]
The is_interface() function in ethmonitor tries to match an interface to a list obtained from the 'ip' tool. It lists interfaces using the 'inet' family, which omits interfaces that don't have an IP address assigned.

If the interface that we're looking for is e.g. a VLAN bridge that does
not have an IP address, it won't show up in the listing and
is_interface() will return false. ethmonitor will miss that interface,
and it won't be available for monitoring.

Upstream commits:
- https://github.com/ClusterLabs/resource-agents/commit/40d05029ce0b 
- https://github.com/ClusterLabs/resource-agents/commit/c0ac191c73f1

[Test Case]
1) Ensure there's a network interface without an assigned IP address. For example, virbr0-nic will be created automatically by uvt-kvm:
# ip addr show dev virbr0-nic
11: virbr0-nic: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel master virbr0 state DOWN group default qlen 1000
    link/ether 52:54:00:e9:5e:af brd ff:ff:ff:ff:ff:ff

2) Install pcs+arping and create a new ethmonitor resource with the target interface:
# sudo apt update && sudo apt install pcs arping -y
# pcs resource create p_nic ocf:heartbeat:ethmonitor interface=virbr0-nic op monitor timeout="10s"

3) Debug-start ethmonitor resource and check for "Interface does not exist messages"
# pcs resource debug-start p_nic
Operation start for p_nic (ocf:heartbeat:ethmonitor) returned: 'ok' (0)
 >  stderr: WARNING: Interface virbr0-nic does not exist
 >  stderr: NOTICE: link_status: DOWN

[Regression Potential]
The regression potential is low, since we are relaxing the monitoring conditions for interfaces without an assigned IP address. The patches have been tested against Travis-CI before being merged upstream, and will be tested against autopkgtest for each target distro.

** Affects: resource-agents (Ubuntu)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Fix Committed

** Affects: resource-agents (Ubuntu Xenial)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Confirmed

** Affects: resource-agents (Ubuntu Bionic)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Confirmed

** Affects: resource-agents (Ubuntu Cosmic)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Confirmed

** Affects: resource-agents (Ubuntu Disco)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Confirmed

** Affects: resource-agents (Ubuntu Eoan)
     Importance: Medium
     Assignee: Heitor Alves de Siqueira (halves)
         Status: Fix Committed

** Affects: resource-agents (Debian)
     Importance: Unknown
         Status: New


** Tags: patch sts sts-sponsor
-- 
ethmonitor does not list interfaces without assigned IP address
https://bugs.launchpad.net/bugs/1825250
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.