[Bug 1824370] Re: [needs-packaging] wiringpi

[Simon Quigley]

Hi Dave, thanks for your work on this!

Is there a reason this can't go to Debian first, and then flow down to
Ubuntu? I will be happy to sponsor to Debian.

I have reviewed this package; here are some items which should be addressed:
 1. The current version of debhelper is 12, while this package has 10. Could that be updated?
 2. Standards-version is at 4.1.2, could that be updated to 4.3.0?
 3. Can this package only build on the four architectures you have specified in the PPA? Ubuntu builds for two additional architectures and Debian builds for many more; if it can only build for those four, you should replace "any" in debian/control with a space-separated list of architectures.
 4. After doing a copyright review, I found that some of the files only have a copyright notice for the author, and not the standard LGPL header, which should be fixed upstream. Additionally, in one file, another author is credited: "Additional code for pwmSetClock by Chris Hall <chris at kchall.plus.com>" (wiringPi/wiringPi.c), and in wiringPi/wiringShift.h the copyright dates go back to 2009.

Here's what Lintian returns:
I: wiringpi source: duplicate-short-description libwiringpi2-dev libwiringpi2
P: wiringpi source: package-does-not-install-examples examples/
P: wiringpi source: file-contains-trailing-whitespace debian/changelog (line 27)
P: wiringpi source: package-uses-old-debhelper-compat-version 10
I: wiringpi source: out-of-date-standards-version 4.1.2 (released 2017-11-30) (current is 4.3.0)
I: wiringpi source: testsuite-autopkgtest-missing
X: wiringpi source: upstream-metadata-file-is-missing
I: wiringpi source: debian-watch-uses-insecure-uri http://git.drogon.net/wiringpi.git
I: wiringpi source: debian-watch-contains-dh_make-template (line 1)
X: wiringpi source: debian-watch-does-not-check-gpg-signature
I: libwiringpi2: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libwiringPi.so.2.50 certianly certainly
I: libwiringpi2: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libwiringPi.so.2.50
I: libwiringpi2: hardening-no-bindnow usr/lib/x86_64-linux-gnu/libwiringPiDev.so.2.50
I: libwiringpi2: no-symbols-control-file usr/lib/x86_64-linux-gnu/libwiringPi.so.2.50                                                                                                                                                        
I: libwiringpi2: no-symbols-control-file usr/lib/x86_64-linux-gnu/libwiringPiDev.so.2.50
X: wiringpi: application-in-library-section libs usr/bin/gpio
I: wiringpi: extended-description-is-probably-too-short

You can find detailed information about each tag here:
https://lintian.debian.org/tags/

You aren't required to fix all of them (in fact, all of them are info or
lower, so you don't have to), but addressing them would be beneficial
and make a higher-quality package.

Unsubscribing sponsors for now, let me know if you have any questions.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1824370

Title:
  [needs-packaging] wiringpi

Status in Ubuntu:
  In Progress

Bug description:
  On the Raspberry Pi platform, the wiringpi package provides (yet
  another, but still a very popular) interface to drive the GPIO pins
  for a variety of functions (straight input and output, SPI, I2C, etc).
  It also provides the exceedingly useful "gpio" command line utility
  which many users find essential when debugging electrical circuits
  attached to the GPIO pins (in particular, its "readall" feature prints
  the position, mode, and state of all pins in a handy form including
  several pin numbering variations).

  URL: http://wiringpi.com/
  License: LGPL3+

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1824370/+subscriptions