[Bug 1824102] Re: Animations leave window artifacts when enabled

[Łukasz Zemczak]

Hello fossfreedom, or anyone else affected,

Accepted budgie-desktop into bionic-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/budgie-
desktop/10.4+git20171031.10.g9f71bb8-1.2ubuntu1.2 in a few hours, and
then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: budgie-desktop (Ubuntu Bionic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1824102

Title:
  Animations leave window artifacts when enabled

Status in budgie-desktop package in Ubuntu:
  Fix Released
Status in budgie-desktop source package in Bionic:
  Fix Committed
Status in budgie-desktop source package in Cosmic:
  Fix Committed
Status in budgie-desktop source package in Disco:
  Fix Released

Bug description:
  This SRU issue specifically resolves window animation issues caused by
  newer versions of mutter - later than the current version in 18.04LTS.

  This SRU is part of LP: #1824229 for 18.04 & 18.10 where additional
  disco fixes have been backported.

  For 19.04, only the animation fix has been applied (see the attached
  disco.debdiff)

  [Impact]

   * For Cosmic and Disco, animations when enabled leave visible window
  artifacts when various budgie window elements are opened and closed
  such as menu popovers and alt+tab window..

     This has been reported upstream https://github.com/solus-project
  /budgie-desktop/issues/1627

     The issue is due to changes made in mutter 3.30 and later.

   * The Ubuntu Desktop team for Bionic is also proposing to bring in
  changes in a proposed mutter release which similarly breaks Ubuntu
  Budgie LTS in this area.
  https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/1811900

   * The fix made here is to force a repaint of the window area being
  animated.  Current testing have not shown any noticable user facing
  impacts such as slow/sluggish animation effects.

  [Test Case]
   18.04: Start from current 18.04 Ubuntu Budgie fully up-to-date.

   * Open budgie-desktop-settings - on the Style tab ensure animations is enabled.
     - Open the menu 3 or 4 times.  Note that the menu opens and closes correctly 
     - Open 3 or 4 apps.  Alt+Tab.  Repeat several times. No obvious window artifacts are displayed

   * To upgrade budgie-desktop on 18.04 - Enable the proposed channel.
  Install the following packages: budgie-core budgie-desktop
  gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0

   * After a reboot and login repeat the menu opening and alt+tab
  actions above.  Note that animations are still displayed correctly
  without any obvious window artifacts being displayed.

  18.04 + mutter uplift: enable the proposed repository and install
  libmutter-2-0. Reboot.

     - Open the menu 3 or 4 times.  Note that the background edge of the menu remains visible on the desktop but disappears when you move your mouse over the area.
     - Open 3 or 4 apps.  Alt+Tab.  Repeat several times. Most times (not always) the alt+tab window does not fully disappear until the mouse is moved over it.
   * To upgrade budgie-desktop on 18.04 + mutter - with the proposed channel still enabled. Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0

   * After a reboot and login repeat the menu opening and alt+tab
  actions above.  Note that animations are displayed correctly without
  any obvious window artifacts being displayed.

  18.10 & 19.04:

     - Open the menu 3 or 4 times.  Note that the background edge of the menu remains visible on the desktop but disappears when you move your mouse over the area.
     - Open 3 or 4 apps.  Alt+Tab.  Repeat several times. Most times (not always) the alt+tab window does not fully disappear until the mouse is moved over it.
   * To upgrade budgie-desktop on 18.10 & 19.04 - Enable the proposed channel. Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0 libbudgie-private0

   * After a reboot and login repeat the menu opening and alt+tab
  actions above.  Note that animations are displayed correctly without
  any obvious window artifacts being displayed.

  [Regression Potential]

   * The regression potential is that not every budgie animation effect
  passes through the code that has been patched and potentially there
  could be certain budgie animations that may appear "broken".

     If this unlikely scenario occurs, a further SRU would be required
  to resolve edge cases.

     Alternatively, animations can be turned-off as was currently
  implemented in in 18.10 & 19.04

   * Testing by the team + independent testing (https://github.com/solus-project/budgie-desktop/issues/1627)
     have not uncovered any issues. Thus we believe the risks are small.

  [Other Info]

     Without out this SRU, either the migration of LP: #1811900 will
  break budgie animations in 18.04 LTS or it will hold up the mutter
  migration until more discovery work is made by upstream budgie
  developers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/budgie-desktop/+bug/1824102/+subscriptions