[Bug 1824229] Re: [SRU] Cherrypick bug-fixes and usability issues for budgie-desktop

[Brian Murray]

To have a log of this, it'd be easier if there one was bug per issue in
the bug description. As an SRU team member its complicated for me to
track multiple issues in one bug report as for me to verify the SRU
verification was done properly I'm going to have to look through the bug
with a mental checklist of all the issues and look for verification of
each separate issue which is painful.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1824229

Title:
  [SRU] Cherrypick bug-fixes and usability issues for budgie-desktop

Status in budgie-desktop package in Ubuntu:
  In Progress
Status in budgie-desktop source package in Bionic:
  In Progress
Status in budgie-desktop source package in Cosmic:
  In Progress

Bug description:
  This (master) SRU request is to resolve a number of usability and
  crashes reported to the UB team through various channels.

  The key issue is LP: #1824102  which will allow the outstanding bionic
  mutter SRU LP: #1811900 to migrate.  Further details specific to this
  is covered by LP: #1824102

  Changelog summary for Bionic and Cosmic SRU - also see the debdiffs
  for cosmic and bionic

  Hopefully resolve fix polkit crashes reported on errors.ubuntu.com due
  to Polkit dialogs still having an open process when dismissed

  Correctly manage custom keys and hence resolve custom keys not
  occasionally working on logon

  Usability patch to correctly dismiss raven if opened when a workspace
  is switched

  Ensure animations remain working with mutter
  v3.28.3+git20190124-0ubuntu18.04.1 (LP: #1824102)

  Note - LP: #1824102 covers the SRU for disco

  [Impact]

   * Issue 1: Aim to resolve a number of polkit crashes reported on errors.ubuntu.com due
  to Polkit dialogs still having an open process when dismissed

     This backports a disco patch to both series targets. Whilst ack
  that 19.04 has not been released, examining errors.ubuntu.com
  (https://errors.ubuntu.com/problem/64efb30df94e62a4f216cfdb387d6e2d3eb12048)
  shows just one reported polkit issues to-date.

   * Issue 2: Correctly manage custom keys and hence resolve custom keys not
  occasionally working on logon.

     This backports a disco patch to both series targets. Testing over a
  couple of months during the 19.04 cycle shows that custom keyboard
  shortcuts are reliably available after a logout/login or reboot.

   * Issue 3: Usability patch to correctly dismiss raven if opened when a workspace
  is switched

     This backports a commit made to budgie-desktop v10.5 included in
  disco.

   * Issue 4a - cosmic: Re-enable desktop animations that were disabled due to mutter changes.
     Issue 4b - bionic: Ensure desktop animations remain working when bionic proposed mutter package migrates to release

     Further details covered by LP: #1824102 and test-cases etc covered
  by that issue report

  [Test Case]

   * Issue 1: polkit crashes. This bug is very difficult to pin down and reliably reproduce.
     It is surmised by examining the crash reports that the budgie polkit process is crashing due to window close down and memory cleanup areas.
     - Run pkexec gnome-calculator from a terminal.
     - Press cancel on the authentication dialog.  Note that the terminal prompt is not redisplayed indicating that the polkit dialog is still active but hidden.  Press CTRL+C to force a quit.
     - To upgrade budgie-desktop on 18.04 - Enable the proposed channel.  Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0
     - To upgrade budgie-desktop on 18.10 - Enable the proposed channel.  Install the following packages: budgie-core budgie-desktop gir1.2-budgie-1.0 libbudgie-plugin0 libbudgietheme0 libraven0 libbudgie-private0
     - Repeat pkexec gnome-calculator and press cancel.  The terminal prompt is redisplayed indicating that the polkit dialog has been successfully closed.

   * Issue 2: This bug is very difficult to pin down and reliably reproduce. For a test case, pressing CTRL+ALT+T  to open a terminal, Super + E to open a file-manager window should always work after a full reboot & login
     Recommend repeat the above for 10 reboots or more after budgie-desktop is upgraded

   * Issue 3: Press Super + N to open raven notifications.  Press CTRL+ALT+Right Arrow.  Note that Raven remains open even though the workspace is changed.
     - Upgrade budgie-desktop, reboot and retry the above.  Raven will now close when the workspace is switched.

   * Issue 4: Covered by LP: #1824102 test cases.

  [Regression Potential]

   * Issue 1: Due to the nature of the crashes observed (unexplained
  crashes in glib, wnck libraries), it is highly unlikely that this fix
  alone will resolve all polkit issues.  In terms of regression the
  number of "system error" prompts with a polkit headline after a reboot
  and login will be either the same or reduced - but such messages can
  be ticked by a user via the system error dialog to not appear again.

   * Issue 2: The likelihood of regression is negligable since the
  handling of custom keys is now how the maintainer of gnome-settings-
  daemon recommends (upstream https://github.com/solus-project/budgie-
  desktop/issues/1763).  In any-case, there is a potential that custom
  key handling will still occur to be not available after a reboot,
  requiring a user to continue using the current workaround of logging
  out and logging in again.

   * Issue 3: The only regression here is that raven remains open during
  a workspace switch.  This is thought highly unlikely from the code
  review undertaken.

  [Other Info]

  N/A

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/budgie-desktop/+bug/1824229/+subscriptions