[Bug 1792905] Re: [2.5] iSCSI systemd services fails and blocks for 1 min 30 secconds

[Ubuntu Foundations Team Bug Bot]

The attachment "debdiff for Cosmic." seems to be a debdiff.  The ubuntu-
sponsors team has been subscribed to the bug report so that they can
review and hopefully sponsor the debdiff.  If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe
the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1792905

Title:
  [2.5] iSCSI systemd services fails and blocks for 1 min 30 secconds

Status in cloud-images:
  Triaged
Status in MAAS:
  Triaged
Status in livecd-rootfs package in Ubuntu:
  New
Status in open-iscsi package in Ubuntu:
  Confirmed
Status in livecd-rootfs source package in Xenial:
  Invalid
Status in open-iscsi source package in Xenial:
  New
Status in livecd-rootfs source package in Bionic:
  New
Status in open-iscsi source package in Bionic:
  New
Status in livecd-rootfs source package in Cosmic:
  New
Status in open-iscsi source package in Cosmic:
  Confirmed

Bug description:
  [Impact]

   * Affects environments where the base image is read-only but kernel
  modules are copied to a tempfs or other overlay mounted on
  /lib/modules.

   * This affects users of our stable release images available from http
  ://cloud-images.ubuntu.com.

   * The attached fixes ensure /lib/modules always exists by creating it
  explicitly instead of relying on it to come from a package.

  [Test Case]

   * Download http://cloud-images.ubuntu.com/bionic/current/bionic-
  server-cloudimg-amd64.squashfs

   * Unpack it via `sudo unsquashfs bionic-server-cloudimg-
  amd64.squashfs`

   * Inspect the unpacked root filesystem and find that '/lib/modules'
  is missing.

   * Install local build scripts as described at
  https://github.com/chrisglass/ubuntu-old-fashioned (note: you will
  need ubuntu-old-fashioned master for cosmic)

  * Re-build the images using the updated livecd-rootfs package.

  * Unpack the resulting livecd.ubuntu-cpc.squashfs artifact using
  unsquashfs again.

  * Inspect the unpacked root filesystem and find that '/lib/modules'
  exists.

  * It is pure luck that package purges which are done analogously in
  Cosmic image builds do not remove '/lib/modules', hence this fix is
  introduced there, as well.

  * Xenial is not affected.

  * Test builds were carried out for Cosmic and Bionic with the expected
  results.

  [Regression Potential]

   * This is a fix to a regression. The existence of the directory had
  previously been ensured, but the mkdir call got lost in recent re-
  factoring. See also:

  https://bazaar.launchpad.net/~ubuntu-core-dev/livecd-rootfs/bionic-
  proposed/revision/1678

  https://bazaar.launchpad.net/~ubuntu-core-dev/livecd-
  rootfs/trunk/revision/1681

   * Packaging tools should not take offense at the existence of a
  directory, even if it was not part of a package. So potential for
  unforseeable regressions is very low.

  ===ORIGINAL BUG DESCRIPTION===

  Let me first start with saying MAAS is *not* using iSCSI anymore and
  is *NOT* in this case either.

  For some reason now using enlistment, commissioning, and deploying the
  ephemeral environment will block for 1 min 30 seconds waiting for the
  iSCSI daemon to succeed, which it never does.

  This increases the boot time drastically.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-images/+bug/1792905/+subscriptions