[Bug 1788219] Re: backport upstream landscape-client fixes

[Ubuntu Foundations Team Bug Bot]

The attachment "cosmic.debdiff" seems to be a debdiff.  The ubuntu-
sponsors team has been subscribed to the bug report so that they can
review and hopefully sponsor the debdiff.  If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe
the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1788219

Title:
  backport upstream landscape-client fixes

Status in landscape-client package in Ubuntu:
  New

Bug description:
  [Impact]

  This bug is for inclusion of a limited collection of upstream fixes affecting
  some of landscape features such as

   * The dmi id for Nutanix cloud instances was added to the detection list
     for it to be properly detected as KVM.

   * Various corrections related to release-upgrades (LP: #1699179) performed
     by landscape. Those should address cases of failure to upgrade, failure
     to report upgrade success, failure to reboot after an upgrade.

   * Decoding of unicode tags when running scripts and using python3 client.
     This change is intentionally left out of trusty and xenial clients, for
     which landscape-client run on python2.7 and is different enough in
     its encoding handling. (LP: #1765518)

  [Test Case]

   * Tagging a client with accented characters and running a simple
     "echo script" should be enough to validate the encoding change.

   * For the release-upgrade, one should be able to trigger one from landscape
     running on trusty or xenial. That upgrade should be reported as a success
     by landscape. A reboot command following that upgrade should also
     work, accompanied by a report of systemd errors which may have been raised
     during the action.

  [Regression Potential]

   * The hypervisor change is both trivial and similar to previous
  changes.

   * The tag encoding change for scripts is equally trivial for recent clients.
     It affects only code related to running shell script and, assuming bad
     system encoding, should still work the same for ASCII tags.
     However, the nature of python2.7 handling of encoding for trusty and xenial
     is different enough for this patch not to be included for them, thus
     avoiding regressions on those clients.

   * The patch which avoids apt-locks during an upgrade does have some potential
     attached. However since it's already released in bionic and cosmic,
     it's fairly well tested.

   * The upgrade success reporting patch should be safe as it's only an earlier
     import of a library which will get touched during the upgrade. Worst case
     scenario, it would only fail faster.

   * The reboot patch is not quite trivial but should be safe. It only adds an
     additional error handler in cases where shutdown command fails in order
     to try an additional method. Normal success behaviour is unchanged.

  [Other Info]

   * Patches are already in the upstreams trunk.
   * Those changes have been tested by some affected users

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/1788219/+subscriptions