[Bug 1744941] Re: gnome-software crashes in as_app_parse_desktop_file

[Marco Trevisan (Treviño)]

** Description changed:

+ [ Impact ]
+ 
+ Malformed .desktop files might causes crashes because
+ the returned list is NULL.
+ 
+ [ Test case ]
+  - Download and copy in one of your XDG_DATA_DIRS (i.e. ~/.local/share/applications)
+    this .desktop file:
+    https://github.com/hughsie/appstream-glib/files/1656100/org.gnome.frogr.desktop.gz
+  - Run gnome-software it must not crash.
+ 
+ [ Regression potential ]
+ 
+ Missing metadata from .desktop files, but really this is just a null-
+ checks fix, so not really anything might go worse.
+ 
+ 
+ ----
+ 
  See more at upstream bug: https://github.com/hughsie/appstream-
  glib/pull/221
  
  This affects all the releases since xenial.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1744941

Title:
  gnome-software crashes in as_app_parse_desktop_file

Status in appstream-glib package in Ubuntu:
  In Progress
Status in appstream-glib source package in Xenial:
  New
Status in appstream-glib source package in Artful:
  New
Status in appstream-glib source package in Bionic:
  In Progress

Bug description:
  [ Impact ]

  Malformed .desktop files might causes crashes because
  the returned list is NULL.

  [ Test case ]
   - Download and copy in one of your XDG_DATA_DIRS (i.e. ~/.local/share/applications)
     this .desktop file:
     https://github.com/hughsie/appstream-glib/files/1656100/org.gnome.frogr.desktop.gz
   - Run gnome-software it must not crash.

  [ Regression potential ]

  Missing metadata from .desktop files, but really this is just a null-
  checks fix, so not really anything might go worse.

  
  ----

  See more at upstream bug: https://github.com/hughsie/appstream-
  glib/pull/221

  This affects all the releases since xenial.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/appstream-glib/+bug/1744941/+subscriptions