[Bug 1736576] Re: apt related unit test errors in artful, bionic

[Damiön la Bagh]

This is still broken in Bionic with landscape-client 
The proposed patch does not work.

landscape-client:
  Geïnstalleerd: 18.01-0ubuntu3.1
  Kandidaat:     18.01-0ubuntu3.1
  Versietabel:
 *** 18.01-0ubuntu3.1 500
        500 http://nl.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     18.01-0ubuntu3 500
        500 http://nl.archive.ubuntu.com/ubuntu bionic/main amd64 Packages

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/twisted/internet/defer.py", line 653, in _runCallbacks
    current.result = callback(current.result, *args, **kw)
  File "/usr/lib/python3/dist-packages/landscape/client/package/reporter.py", line 95, in <lambda>
    result.addCallback(lambda x: self.detect_changes())
  File "/usr/lib/python3/dist-packages/landscape/client/package/reporter.py", line 543, in detect_changes
    deferred = self.detect_packages_changes()
  File "/usr/lib/python3/dist-packages/landscape/client/package/reporter.py", line 551, in detect_packages_changes
    if self._got_task or self._package_state_has_changed():
  File "/usr/lib/python3/dist-packages/landscape/client/package/reporter.py", line 577, in _package_state_has_changed
    last_changed = os.stat(f).st_mtime
FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/apt/lists/_var_lib_landscape_client_package_binaries_._Packages'

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1736576

Title:
  apt related unit test errors in artful, bionic

Status in Landscape Client:
  Fix Released
Status in landscape-client package in Ubuntu:
  Fix Released
Status in landscape-client source package in Bionic:
  Fix Released

Bug description:
  [Impact]

   * This bug is a regression in landscape-client, caused by
     apt sources being now verified by apt-secure unless explicitly
     excluded. This effectively breaks landscape package profiles,
     which uses temporary file-local (file://path) source list entry
     containing the package policy for that client.
   * This backported fix adds the "trusted" option to temporary
     file-local sources created by landscape, in order to skip
     the apt-secure validation only on those. This was previously 
     the behaviour prior to yakkety.

  [Test Case]

  Test scenario
   * Register a client with landscape.
   * Create a package profile and associate it with the client.
   * Check the profile is applied successfully.

  Additionally, test failures of the exercised code were fixed as part of
  this change in landscape.package.tests.test_facade/test_changer.

  [Regression Potential]

  * There is no regression anticipated, the functionality using this code path
    is already non-functional.
  * The affected code is only used as part of package profiles application,
    and the option is strictly for a single "file://" source, it should be
    fairly safe to change.

  [Other Info]

   * Upstream commit: https://github.com/CanonicalLtd/landscape-
  client/commit/d640643a15414b0d8e4330179e11d5a6036a6e42

  [Original Description]

  I'm seeing several unit test errors in zesty, artful and bionic.

  The list:
  a) landscape.package.tests.test_changer.AptPackageChangerTest
  all of the type:
  "landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpd_58Jb', 'components': ''}])
  "

  b) landscape.package.tests.test_facade.AptFacadeTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmproQ91z', 'components': ''}])

  c) landscape.package.tests.test_changer.AptPackageChangerTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpLhCd_i', 'components': ''}])

  d) landscape.package.tests.test_reporter.PackageReporterAptTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpaHngJ2', 'components': ''}])

  e) landscape.package.tests.test_skeleton.SkeletonAptTest
  apt.cache.FetchFailedException: E:The repository 'file:/tmp/tmpLVhCZR ./ Release' does not have a Release file.

  This was using 16.03 plus the patch from
  https://bugs.launchpad.net/ubuntu/+source/landscape-
  client/+bug/1699179

To manage notifications about this bug go to:
https://bugs.launchpad.net/landscape-client/+bug/1736576/+subscriptions