[Bug 1736576] Re: apt related unit test errors in artful, bionic

[Simon Poirier]

** Description changed:

+ [Impact]
+ 
+  * This bug is a regression in landscape-client, caused by
+    apt sources being now verified by apt-secure unless explicitly
+    excluded. This effectively breaks landscape package profiles,
+    which uses temporary file-local (file://path) source list entry
+    containing the package policy for that client.
+  * This backported fix adds the "trusted" option to temporary
+    file-local sources created by landscape, in order to skip
+    the apt-secure validation only on those. This was previously 
+    the behaviour prior to yakkety.
+ 
+ [Test Case]
+ 
+ Test scenario
+  * Register a client with landscape.
+  * Create a package profile and associate it with the client.
+  * Check the profile is applied successfully.
+ 
+ Additionally, test failures of the exercised code were fixed as part of
+ this change in landscape.package.tests.test_facade/test_changer.
+ 
+ [Regression Potential]
+ 
+ * There is no regression anticipated, the functionality using this code path
+   is already non-functional.
+ * The affected code is only used as part of package profiles application,
+   and the option is strictly for a single "file://" source, it should be
+   fairly safe to change.
+ 
+ [Other Info]
+ 
+  * Upstream commit: https://github.com/CanonicalLtd/landscape-
+ client/commit/d640643a15414b0d8e4330179e11d5a6036a6e42
+ 
+ [Original Description]
+ 
  I'm seeing several unit test errors in zesty, artful and bionic.
  
  The list:
  a) landscape.package.tests.test_changer.AptPackageChangerTest
  all of the type:
  "landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpd_58Jb', 'components': ''}])
  "
  
  b) landscape.package.tests.test_facade.AptFacadeTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmproQ91z', 'components': ''}])
  
- 
  c) landscape.package.tests.test_changer.AptPackageChangerTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpLhCd_i', 'components': ''}])
  
  d) landscape.package.tests.test_reporter.PackageReporterAptTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpaHngJ2', 'components': ''}])
  
  e) landscape.package.tests.test_skeleton.SkeletonAptTest
  apt.cache.FetchFailedException: E:The repository 'file:/tmp/tmpLVhCZR ./ Release' does not have a Release file.
  
- 
- This was using 16.03 plus the patch from https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/1699179
+ This was using 16.03 plus the patch from
+ https://bugs.launchpad.net/ubuntu/+source/landscape-client/+bug/1699179

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1736576

Title:
  apt related unit test errors in artful, bionic

Status in Landscape Client:
  Fix Committed
Status in landscape-client package in Ubuntu:
  Confirmed
Status in landscape-client source package in Artful:
  Confirmed
Status in landscape-client source package in Bionic:
  Confirmed

Bug description:
  [Impact]

   * This bug is a regression in landscape-client, caused by
     apt sources being now verified by apt-secure unless explicitly
     excluded. This effectively breaks landscape package profiles,
     which uses temporary file-local (file://path) source list entry
     containing the package policy for that client.
   * This backported fix adds the "trusted" option to temporary
     file-local sources created by landscape, in order to skip
     the apt-secure validation only on those. This was previously 
     the behaviour prior to yakkety.

  [Test Case]

  Test scenario
   * Register a client with landscape.
   * Create a package profile and associate it with the client.
   * Check the profile is applied successfully.

  Additionally, test failures of the exercised code were fixed as part of
  this change in landscape.package.tests.test_facade/test_changer.

  [Regression Potential]

  * There is no regression anticipated, the functionality using this code path
    is already non-functional.
  * The affected code is only used as part of package profiles application,
    and the option is strictly for a single "file://" source, it should be
    fairly safe to change.

  [Other Info]

   * Upstream commit: https://github.com/CanonicalLtd/landscape-
  client/commit/d640643a15414b0d8e4330179e11d5a6036a6e42

  [Original Description]

  I'm seeing several unit test errors in zesty, artful and bionic.

  The list:
  a) landscape.package.tests.test_changer.AptPackageChangerTest
  all of the type:
  "landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpd_58Jb', 'components': ''}])
  "

  b) landscape.package.tests.test_facade.AptFacadeTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmproQ91z', 'components': ''}])

  c) landscape.package.tests.test_changer.AptPackageChangerTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpLhCd_i', 'components': ''}])

  d) landscape.package.tests.test_reporter.PackageReporterAptTest
  landscape.package.facade.ChannelError: Apt failed to reload channels ([{'distribution': './', 'type': 'deb', 'baseurl': 'file:///tmp/tmpaHngJ2', 'components': ''}])

  e) landscape.package.tests.test_skeleton.SkeletonAptTest
  apt.cache.FetchFailedException: E:The repository 'file:/tmp/tmpLVhCZR ./ Release' does not have a Release file.

  This was using 16.03 plus the patch from
  https://bugs.launchpad.net/ubuntu/+source/landscape-
  client/+bug/1699179

To manage notifications about this bug go to:
https://bugs.launchpad.net/landscape-client/+bug/1736576/+subscriptions