[Bug 1765389] Re: [FFe] Drop unrelated changes from revert-prce2.patch

[Egmont Koblinger]

Yes please :)

Copying from a previous email, for public record:

"""
I honestly don't _exactly_ know what the revert-pcre2 patch does (how it influences the API etc.), I only ported it from 0.48 to 0.52. The parts you're pointing to were already present in the 0.48 version. I have no clue how and why they got there.

That being said, they are indeed irrelevant to the pcre2 issue, and if those changes are required for whatever reason then they should at the very least reside in a separate patch, pointing to its bug entry at the top of the file. My best guess is that this was introduced accidentally and is simply a bug – as you confirm it causes troubles for you in the gir/vapi binding.
"""

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1765389

Title:
  [FFe] Drop unrelated changes from revert-prce2.patch

Status in vte2.91 package in Ubuntu:
  Confirmed

Bug description:
  There is an issue with revert-prce2.patch of vte2.91. It includes some unrelated reverts which
  are changing the gir/vapi API in unnecessary ways compared to vanilla upstream.

  Test-Build:
  https://launchpad.net/~ricotz/+archive/ubuntu/staging/+sourcepub/8991295/+listing-archive-extra

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/vte2.91/+bug/1765389/+subscriptions