[Bug 1686183] Re: Ship ubuntu-advantage in ubuntu-minimal

Fri Sep 22 22:22:43 UTC 2017

Thanks for the feedback.

On Fri, Sep 22, 2017 at 05:46:36PM -0000, bp wrote:
> You can skip this paragraph if you're in a hurry.  First, thank you for
> holding this discussion in the open.  I totally understand the marketing
> reasons for this: I depend on Canonical's distribution, and want Canonical
> to offer their paying customers a fantastic out-of-the-box experience so
> that they can continue to offer their services to the general public, too.

I want to be clear that, although Canonical benefits financially from users
signing up for paid extended support through ESM, the rationale for
including the package in ubuntu-minimal is not a "marketing" one.  Rather,
the intent is to ensure users who have opted into the paid ESM service have
a seamless process for enabling it on their system.  We do want users whose
systems are EOL and no longer security supported to know what their options
are (upgrades, or paid ESM), but including ubuntu-advantage-tools in
ubuntu-minimal is not intended to discourage users from upgrading.

> That said, the ubuntu-advantage-tools package is not in fact strictly
> necessary to allow the machine to boot, detect hardware, connect to a
> network, install packages or perform basic diagnostics. With ubuntu-
> minimal 1.400, this is now essentially a mandatory piece of software
> that will, at best, emit an error message.

There are a number of packages pulled in by ubuntu-minimal that could be
removed and still technically fulfill the capabilities listed in the
package's description; they would just make it more inconvenient and awkward
to do so.

ubuntu-advantage-tools certainly falls under the header of 'install
packages' - which is more than can be said of e.g. the tzdata and locales
packages.

As far as emitting error messages: while none of the package services
currently provided by this tool are available on non-LTS releases, it is not
impossible that these would be available in the future depending on
commercial demand.  In the meantime, I think it's a far better user
experience to run the documented command and be told 'this service not
available for this release' than to try to run it and be told 'command not
found', and it was with this in mind that I supported including this package
in non-LTS releases.

> Would changing the relationship from Depends to Recommends meet your
> requirements (automatic setup on every Ubuntu machine) while allowing
> manual removal of the package?

We would have to verify this empirically.  I'm not altogether opposed to it,
but I also don't see what advantage it brings our users.  The
ubuntu-advantage-tools package is:

Installed-Size: 36.9 kB
Download-Size: 11.3 kB

and has zero added dependencies.  And most of the current size is the
archive keys, which if they weren't in ubuntu-advantage-tool would certainly
be in ubuntu-keyring (and indeed, we might still move them there), which is
also part of ubuntu-minimal.

So from a technical point of view, what benefit is there to making the
package removable?

I would note that it would be entirely possible to bundle these scripts with
some other base package; and I think it's really only because this is a
separate package that it attracts notice and invites the suggestion to make
it removable.  Otherwise, having one more command in /usr/bin that goes
unused would not be cause for concern.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1686183

Title:
  Ship ubuntu-advantage in ubuntu-minimal

Status in ubuntu-advantage-tools package in Ubuntu:
  Fix Released
Status in ubuntu-meta package in Ubuntu:
  Fix Released
Status in ubuntu-advantage-tools source package in Precise:
  Fix Released
Status in ubuntu-meta source package in Precise:
  Fix Released
Status in ubuntu-advantage-tools source package in Trusty:
  Fix Released
Status in ubuntu-meta source package in Trusty:
  Confirmed
Status in ubuntu-advantage-tools source package in Xenial:
  Fix Released
Status in ubuntu-meta source package in Xenial:
  Confirmed
Status in ubuntu-advantage-tools source package in Yakkety:
  Won't Fix
Status in ubuntu-meta source package in Yakkety:
  Won't Fix
Status in ubuntu-advantage-tools source package in Zesty:
  Fix Released
Status in ubuntu-meta source package in Zesty:
  Confirmed
Status in ubuntu-advantage-tools source package in Artful:
  Fix Released
Status in ubuntu-meta source package in Artful:
  Fix Released

Bug description:
  The ubuntu-advantage-tools package is a bit odd as it was first landed
  in precise to support the ESM effort inside canonical. [0]  In order
  to bring this package up to date across other series in ubuntu, it has
  been recommended by the Ubuntu Foundations team to land into trusty
  next, then forward-port pocket-copy to all supported series until we
  get to the devel release.

  The version here:

  https://github.com/CanonicalLtd/ubuntu-advantage-
  script/releases/tag/v2

  ... has all on-disk bits correctly working, for all series, but no-ops
  on any release other than precise (ESM is only for "unsupported" LTS
  releases as it were).  This is a request to land ubuntu-advantage-
  tools into trusty, then pocket-copy it to supported series of ubuntu
  once that is finished.

  [Impact]

   * Allow ubuntu-advantage users to access the extended security
  maintenance script with a simple command line tool.  This script needs
  to hit precise machines and be easy for ubuntu-advantage customers to
  enable, thus basefiles was chosen as a home.

  [Test Case]

   * Run ubuntu-advantage, it should print out help

   * Run sudo ubuntu-advantage enable <token> (without sudo it will warn
  you), but you need to be an ubuntu-advantage customer to get that
  token.  In the end, the script simply adds and removes an
  /etc/apt/sources.list.d entry.

   * Verify that the MOTD does not contain any mention of ubuntu-
  advantage esm or precise and its end of life

   * Verify that ubuntu-advantage enable-esm <token> installs needed dependencies:
    - create the following file and its contents to have apt not install recommended packages by default:
  $ cat /etc/apt/apt.conf.d/no-recommends
  APT::Install-Recommends "false";
    - remove ca-certificates and apt-transport-https:
  $ sudo apt remove ca-certificates apt-transport-https
    - run sudo ubuntu-advantage enable-esm <token> and verify that the two removed packages are reinstalled

   * you can contact me (dpb at canonical.com) if you would like a token
  for test purposes.

  [Regression Potential]

   * Low, this is a new script, not included in any automated startup
  paths.

  [Other Info]

   * http://blog.dustinkirkland.com/2017/03/ubuntu-1204-esm.html

  [0] https://insights.ubuntu.com/2017/03/14/introducing-ubuntu-12-04
  -esm-extended-security-maintenance/

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1686183/+subscriptions