[Bug 1619654] Re: patch - fix Caja crash on unchecking "Show hidden and backup files" in prefs dialog

[Simon Quigley]

Uploaded.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1619654

Title:
  patch - fix Caja crash on unchecking "Show hidden and backup files" in
  prefs dialog

Status in caja package in Ubuntu:
  Fix Released
Status in caja source package in Xenial:
  In Progress

Bug description:
  [Impact]

  Due to a bug in Caja code, users see it crashing when they uncheck the
  "Show hidden and backup files" in the prefs dialog. It had been fixed
  in version 1.14.1, but it would be nice to backport it as a patch for
  1.12, which is the default version in Ubuntu MATE 16.04 (if not using
  the PPA).

  Patch is provided in the attachment below.

  [Test Case]

  0. Have Ubuntu MATE 16.04 with MATE 1.12 (no xenial-mate PPA enabled).
  1. Open Caja prefs dialog.
  2. If "Show hidden and backup files" isn't checked, check it, then close the dialog and then open it again. That's because the item should be checked first in order to trigger the bug.
  3. Now uncheck "Show hidden and backup files".
  4. Caja crashes.

  [Regression Potential]

  During several months of testing the fix in 1.14, I haven't found any
  regressions. The fix does affect quite small part of code, so
  regression potential in regards to the whole functionality of Caja
  should be very low.

  [Other Info]

  Source of patch: https://github.com/mate-desktop/caja/commit/9a86c2cbc0b1e75f9073461ead8bc2d917694921
  Upstream bug report: https://github.com/mate-desktop/caja/issues/326
  Debian bug report: https://bugs.debian.org/797723

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/caja/+bug/1619654/+subscriptions