[Bug 1721272] Re: Create 'ua' symlink pointing at 'ubuntu-advantage'
ChristianEhrhardt
1721272 at bugs.launchpad.net
Fri Nov 3 13:54:29 UTC 2017
So as mentioned before this has a bit of back and forth, ignoring that the effective changes are:
- not renaming, but aliasing to "ua"
- fixup and enable tests on build (was requested on a former review)
- I checked, the symlinks are good after install
- I checked the tests are running fine on build
- I verified that the debdiff changes 100% match the git changes they are based on
- I don't mind that the changelog has v11/v12 being mostly a revert, that is the "true" changelog, so I agree to keeping it.
>From our IRC discussion I know that you already know that some of this
hardly backports for different constraints, so I don't need to mention
that - for Bionic and that is important now that LGTM. I'd only have
been concerned on the "ua" namespace, but since Steve acked that in c#3
I'm good.
Sponsored into Bionic as of now, since the last released version was 10
I built with -v10.
@Andreas - please track migration (which might take a while for the dep8
tests to run atm), to trigger the SRUs at the right time.
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1721272
Title:
Create 'ua' symlink pointing at 'ubuntu-advantage'
Status in ubuntu-advantage-tools package in Ubuntu:
In Progress
Bug description:
[Impact]
We want to add a short alias named 'ua' to the ubuntu-advantage script.
This can be easily accomplished by creating a 'ua' symlink pointing at the 'ubuntu-advantage' script. Likewise for its manpage.
Documentation and tests were updated.
Full diff of all changes on github: https://github.com/CanonicalLtd
/ubuntu-advantage-script/compare/v10...v13
v13 also enables running the tests during package build (as requested
by SRU verification team (sil2100)).
[Test Case]
{ua symlink}
* Install v13 ubuntu-advantage-tool package
* Look if symlink "/usr/bin/ua" exist, pointing to /usr/bin/ubuntu-advantage and working.
* Validate "man ua" which should display the manpage of its symlink TARGET "/usr/bin/ubuntu-advantage"
Basically "ubuntu-advantage" script or symlink "ua" can be use to
perform the same set of tasks.
{Testsuite at build time}
* Look the buildlog and make sure dh_auto_test succeed as follow :
Output took from PPA build test :
debian/rules override_dh_auto_test
python3 -m unittest discover tests
Ran 55 tests in 4.995s
OK
[Regression Potential]
* Regression is low
* First, the fix incorporate the testsuite at build time (as
requested by SRU verification team), so no effect on the actual source
code and secondly, it introduce a new symlink "ua" pointing to an
existing script "ubuntu-advantage"
[Other Info]
GitHub Upstream commit:
https://github.com/CanonicalLtd/ubuntu-advantage-script/commit/9963f1907a5f13c705bbeaa7e8c8dd2bfa0eee84
[Original Description]
We want to add a short alias named 'ua' to the ubuntu-advantage script.
This can be easily accomplished by creating a 'ua' symlink pointing at the 'ubuntu-advantage' script. Likewise for its manpage.
Documentation and tests were updated.
Full diff of all changes on github: https://github.com/CanonicalLtd
/ubuntu-advantage-script/compare/v10...v13
v13 also enables running the tests during package build.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions
More information about the Ubuntu-sponsors
mailing list