[Bug 1671767] Re: asterisk crashes dialing h264 video sip device

[Nish Aravamudan]

** Changed in: asterisk (Ubuntu)
       Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1671767

Title:
  asterisk crashes dialing h264 video sip device

Status in asterisk package in Ubuntu:
  Fix Released
Status in asterisk source package in Xenial:
  New

Bug description:
  [Impact]
  ========
  when dialing a h264 video sip device (Grandstream GXV3674_FHD_VF 1.0.3.17) asterisk crashes with a core dump

  [Test Case]
  ===========
  1. See comment #6

  [Regression Potential]
  ======================
  Since the patch is already included in more recent versions of asterisk there is no regression.

  Due to the location of code changes that are applied to - If an
  unexpected error manifests, it should be local to the h264 encoding
  which is broken today.

  [Other Info]
  ============
  none

  ---

  asterisk 1:13.1.0~dfsg-1.1ubuntu4

  lsb_release -rd:
  Description:	Ubuntu 16.04.2 LTS
  Release:	16.04

  Bug details:
  ============
  when dialing a h264 video sip device (Grandstream GXV3674_FHD_VF 1.0.3.17) asterisk crashes with a core dump:

  Connected to Asterisk 13.1.0~dfsg-1.1ubuntu4 currently running on samson (pid = 29051)
  samson*CLI> console dial waldorf at Phones
      -- Executing [waldorf at Phones:1] Dial("Console/default", "SIP/waldorf,60") in new stack
    == Using SIP VIDEO CoS mark 6
    == Using SIP RTP CoS mark 5
      -- Called SIP/waldorf
      -- SIP/waldorf-00000000 is ringing
  samson*CLI>
  Disconnected from Asterisk server
  Asterisk cleanly ending (0).
  Executing last minute cleanups

  Analysis:
  =========
  gdb reveals that the module "res_format_attr_h264.so" is resposible due to a memory allocation failure while examining tokens of the "sprop-parameter-sets" string in the SIP header.

  Proposed Solution:
  ==================
  This bug is already fixed by 2 small patches included in a more recenent versions of "res/res_format_attr_h264.c"

  https://issues.asterisk.org/jira/browse/ASTERISK-24616
  Crash in res_format_attr_h264 due to invalid string copy

  https://issues.asterisk.org/jira/browse/ASTERISK-25573
  [patch] H.264 format attribute module: resets whole SDP

  This fixed version of "res/res_format_attr_h264.c" is included e.g. in
  asterisk (1:13.13.1~dfsg-4ubuntu1) zesty.

  Fixed+Tested:
  =============
  I tested by rebuiling asterisk 1:13.1.0~dfsg-1.1ubuntu4 packages with the "res/res_format_attr_h264.c" taken from asterisk 1:13.13.1~dfsg-4ubuntu1 and could connect to the sip device without any problems.

  I would be great, if you could add this patch into asterisk
  1:13.1.0~dfsg-1.1ubuntu4, since I don't want to use self built debs on
  a 16.4 LTS production system.

  Thanks a lot
  Jörg

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/asterisk/+bug/1671767/+subscriptions