[Bug 1670696] Re: Typo in error msg when no crashkernel memory reservation is set

[Eric Desrochers]

Xenial debdiff

** Patch added: "xenial.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1670696/+attachment/4832995/+files/xenial_makedumpfile.debdiff

** Description changed:

  [Impact]
  
   * There is a typo in ERRMSG of function show_mem_usage affecting Xenial
  and Zesty AND Debian.
  
  This should be :
  "show_mem_usage: No memory is reserved for crashkernel!"
  
  instead of :
  "show_mem_usage: No memory is reserved for crashkenrel!"
+ 
+ The typo is located here in src code for Xenial and Zesty (devel
+ release) AND Debian:
+ 
+ # filename : makedumpfile.c
+ 10447 int show_mem_usage(void)
+ 10448 {
+ 10449         uint64_t vmcoreinfo_addr, vmcoreinfo_len;
+ 10450         struct cycle cycle = {0};
+ 10451
+ 10452         if (!is_crashkernel_mem_reserved()) {
+ 10453                 ERRMSG("No memory is reserved for crashkenrel!\n");
+ 10454                 return FALSE;
+ 10455         }
  
  [Test Case]
  
   * Take a system with no crashkernel memory reservation set
   * run command : makedumpfile --mem-usage /proc/kcore
  
   * Error message :
  show_mem_usage: No memory is reserved for crashkenrel!
  
  [Regression Potential]
  
   * No regression, it is a trivial change with no behavioural change.
  
  [Other Info]
  
- The typo is located here in src code for Xenial and Zesty (devel
- release) AND Debian:
- 
- # filename : makedumpfile.c
- 10447 int show_mem_usage(void)
- 10448 {
- 10449         uint64_t vmcoreinfo_addr, vmcoreinfo_len;
- 10450         struct cycle cycle = {0};
- 10451
- 10452         if (!is_crashkernel_mem_reserved()) {
- 10453                 ERRMSG("No memory is reserved for crashkenrel!\n");
- 10454                 return FALSE;
- 10455         }
- 
- * Debian bug : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051
+ * Debian bug : 
+ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1670696

Title:
  Typo in error msg when no crashkernel memory reservation is set

Status in makedumpfile package in Ubuntu:
  In Progress
Status in makedumpfile source package in Xenial:
  In Progress
Status in makedumpfile source package in Zesty:
  In Progress

Bug description:
  [Impact]

   * There is a typo in ERRMSG of function show_mem_usage affecting
  Xenial and Zesty AND Debian.

  This should be :
  "show_mem_usage: No memory is reserved for crashkernel!"

  instead of :
  "show_mem_usage: No memory is reserved for crashkenrel!"

  The typo is located here in src code for Xenial and Zesty (devel
  release) AND Debian:

  # filename : makedumpfile.c
  10447 int show_mem_usage(void)
  10448 {
  10449         uint64_t vmcoreinfo_addr, vmcoreinfo_len;
  10450         struct cycle cycle = {0};
  10451
  10452         if (!is_crashkernel_mem_reserved()) {
  10453                 ERRMSG("No memory is reserved for crashkenrel!\n");
  10454                 return FALSE;
  10455         }

  [Test Case]

   * Take a system with no crashkernel memory reservation set
   * run command : makedumpfile --mem-usage /proc/kcore

   * Error message :
  show_mem_usage: No memory is reserved for crashkenrel!

  [Regression Potential]

   * No regression, it is a trivial change with no behavioural change.

  [Other Info]

  * Debian bug : 
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857051

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1670696/+subscriptions