[Bug 1684039] Re: iBFT network configuration does not correctly populate PROTO=dhcp in /run/net-*.conf which breaks cloud-init

[Eric Desrochers]

** Description changed:

  [Impact]
  
  When booting with iBFT, the network configuration is performed by open-iscsi as part of initramfs.local-top instead of by klibc-ipconfig. This includes populating /run/net-*.conf which is consumed among other things, by cloud-init.
  Currently no attempt to determine PROTO is made, and PROTO=none is hard coded into the file which cloud-init does not recognise and crashes out.
  Further to this, open-iscsi in the current version (xenial through zesty) does not correctly parse the iBFT origin into the boot protocol in "iscsistart -f" and always returns "STATIC". This is fixed upstream.
  
  [Test Case]
  
  
  [Regression Potential]
  
+ We believe the regression risk is "low" and don't envision any.
+ 
+ The package (including the fixes) has been intensively tested pre-SRU.
+ 
+ If regression is found, it'll be clearly less critical than this actual
+ bug where cloud-init breaks because of this actual missing piece of code
+ and It'll most likely only affect system booting with iBFT.
+ 
+ Additionally, the patches has been proven to work Upstream and Debian
+ for a couple of years now.
  
  [Other Info]
-  
+ 
  * This SRU includes the following upstream/debian fixes :
  
- # Debian: 
+ # Debian:
  0347300 initramfs: populate PROTO= entry in /run/net-*.conf from iBFT
  
  # Upstream
  - 08_Parse-origin-value-from-iBFT.patch --> https://github.com/open-iscsi/open-iscsi/commit/78e24f50ab754f35f4aa208ade7c9fd794d82036#diff-c53311d3f6725aa63577b7bf4b582c3d
  
  - 09_Represent-DHCP-origin-as-an-enum-not-a-string.patch -->
  https://github.com/open-iscsi/open-
  iscsi/commit/4959a89f421fdebc521f48003a79c2161e59d192#diff-
  c53311d3f6725aa63577b7bf4b582c3d
  
  - 10_iBFT-origin-is-an-enum-not-a-string.patch --> https://github.com
  /open-iscsi/open-iscsi/commit/3f15a2270a7efb1a6ee8ef555b01f3d8674818b9
  #diff-3ba89d9a64dda0ffc3664bbc27b0fa27
  
  [Original Description]
  
  When booting with iBFT, the network configuration is performed by open-
  iscsi as part of initramfs.local-top instead of by klibc-ipconfig.  This
  includes populating /run/net-*.conf which is consumed among other
  things, by cloud-init.
  
  Currently no attempt to determine PROTO is made, and PROTO=none is hard
  coded into the file which cloud-init does not recognise and crashes out.
  
  Further to this, open-iscsi in the current version (xenial through
  zesty) does not correctly parse the iBFT origin into the boot protocol
  in "iscsistart -f" and always returns "STATIC".  This is fixed upstream.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1684039

Title:
  iBFT network configuration does not correctly populate PROTO=dhcp in
  /run/net-*.conf which breaks cloud-init

Status in open-iscsi package in Ubuntu:
  Fix Committed
Status in open-iscsi source package in Xenial:
  In Progress
Status in open-iscsi source package in Yakkety:
  Won't Fix
Status in open-iscsi source package in Zesty:
  In Progress
Status in open-iscsi source package in Artful:
  Fix Committed
Status in open-iscsi package in Debian:
  Fix Released

Bug description:
  [Impact]

  When booting with iBFT, the network configuration is performed by open-iscsi as part of initramfs.local-top instead of by klibc-ipconfig. This includes populating /run/net-*.conf which is consumed among other things, by cloud-init.
  Currently no attempt to determine PROTO is made, and PROTO=none is hard coded into the file which cloud-init does not recognise and crashes out.
  Further to this, open-iscsi in the current version (xenial through zesty) does not correctly parse the iBFT origin into the boot protocol in "iscsistart -f" and always returns "STATIC". This is fixed upstream.

  [Test Case]

  
  [Regression Potential]

  We believe the regression risk is "low" and don't envision any.

  The package (including the fixes) has been intensively tested pre-SRU.

  If regression is found, it'll be clearly less critical than this
  actual bug where cloud-init breaks because of this actual missing
  piece of code and It'll most likely only affect system booting with
  iBFT.

  Additionally, the patches has been proven to work Upstream and Debian
  for a couple of years now.

  [Other Info]

  * This SRU includes the following upstream/debian fixes :

  # Debian:
  0347300 initramfs: populate PROTO= entry in /run/net-*.conf from iBFT

  # Upstream
  - 08_Parse-origin-value-from-iBFT.patch --> https://github.com/open-iscsi/open-iscsi/commit/78e24f50ab754f35f4aa208ade7c9fd794d82036#diff-c53311d3f6725aa63577b7bf4b582c3d

  - 09_Represent-DHCP-origin-as-an-enum-not-a-string.patch -->
  https://github.com/open-iscsi/open-
  iscsi/commit/4959a89f421fdebc521f48003a79c2161e59d192#diff-
  c53311d3f6725aa63577b7bf4b582c3d

  - 10_iBFT-origin-is-an-enum-not-a-string.patch --> https://github.com
  /open-iscsi/open-iscsi/commit/3f15a2270a7efb1a6ee8ef555b01f3d8674818b9
  #diff-3ba89d9a64dda0ffc3664bbc27b0fa27

  [Original Description]

  When booting with iBFT, the network configuration is performed by
  open-iscsi as part of initramfs.local-top instead of by klibc-
  ipconfig.  This includes populating /run/net-*.conf which is consumed
  among other things, by cloud-init.

  Currently no attempt to determine PROTO is made, and PROTO=none is
  hard coded into the file which cloud-init does not recognise and
  crashes out.

  Further to this, open-iscsi in the current version (xenial through
  zesty) does not correctly parse the iBFT origin into the boot protocol
  in "iscsistart -f" and always returns "STATIC".  This is fixed
  upstream.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1684039/+subscriptions